Skip to content

[PR] Toolbar enhancement #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 27, 2023
Merged

[PR] Toolbar enhancement #9

merged 10 commits into from
Sep 27, 2023

Conversation

@LuchoTurtle
Copy link
Member

closes #8

This PR will add the requirements detailed in #8.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality flutter Flutter related issues in-progress An issue or pull request that is being worked on by the assigned person labels Sep 25, 2023
@LuchoTurtle LuchoTurtle self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #9 (5b30f58) into main (eadc1ac) will increase coverage by 6.27%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   60.76%   67.04%   +6.27%     
==========================================
  Files           4        5       +1     
  Lines         130      176      +46     
==========================================
+ Hits           79      118      +39     
- Misses         51       58       +7
Files Coverage Δ
lib/emoji_picker_widget.dart 72.22% <72.22%> (ø)
lib/home_page.dart 76.61% <78.78%> (+4.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle mentioned this pull request Sep 25, 2023
Closed
3 tasks
@LuchoTurtle
Copy link
Member Author

As mentioned in #8 (comment), this PR adds the features that are outlined in #8.

Should be reviewable/mergeable.

@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Sep 26, 2023
@LuchoTurtle LuchoTurtle marked this pull request as ready for review September 26, 2023 17:54
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed in-review Issue or pull request that is currently being reviewed by the assigned person and removed in-progress An issue or pull request that is being worked on by the assigned person awaiting-review An issue or pull request that needs to be reviewed labels Sep 27, 2023
nelsonic
nelsonic approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emoji support looks good. 👌

@nelsonic nelsonic merged commit 77bfdc0 into main Sep 27, 2023
@nelsonic nelsonic deleted the toolbar#8 branch September 27, 2023 02:00
@LuchoTurtle LuchoTurtle mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels

documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality flutter Flutter related issues in-review Issue or pull request that is currently being reviewed by the assigned person

Projects

Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Toolbar menu enhancement

2 participants

@LuchoTurtle @nelsonic