-
Notifications
You must be signed in to change notification settings - Fork 0
[PR] Migrating to visual-editor
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 5 5
Lines 176 176
=======================================
Hits 118 118
Misses 58 58 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This should be reviewable 👌 |
It should be 👌 . Again, it's connected to my own fork whilst my PRs aren't yet merged in the original repo. Should be good to go. WHen the PRs are merged, we can make the changes on a separate PR 👍 |
@LuchoTurtle please transfer the |
Let me transfer and make the needed changes, then. |
> | ||
> We will use a **fork of `visual-editor`** - https://github.com/LuchoTurtle/visual-editor in this guide. | ||
> This is because the PR that was opened to `visual-editor` has need yet been merged | ||
> (https://github.com/visual-space/visual-editor/pull/237). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the PR(s) you open to visual-editor
are not being merged after weeks of waiting
and they are legitimately valid enhancements then it could be time to:
a) consider other options
b) use the fork
for the foreseable future and forget the PRs
which will bit-rot ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuchoTurtle 👍
Please transfer the fork
of visual-editor
to @dwyl
so that other people can contribute.
You may merge now. All instances of the old fork have been changed and the repo has been transferred -> https://github.com/dwyl/visual-editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuchoTurtle 🙏
closes #3
This PR migrates the code to
visual-editor
, using my own fork whilst we wait for the changes to occur in the original repo.