Skip to content

Conversation

LuchoTurtle
Copy link
Member

closes #3

This PR migrates the code to visual-editor, using my own fork whilst we wait for the changes to occur in the original repo.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person labels Sep 19, 2023
@LuchoTurtle LuchoTurtle self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #7 (04c2c2c) into main (77bfdc0) will not change coverage.
The diff coverage is n/a.

❗ Current head 04c2c2c differs from pull request most recent head 9285206. Consider uploading reports for the commit 9285206 to get more accurate results

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files           5        5           
  Lines         176      176           
=======================================
  Hits          118      118           
  Misses         58       58           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

This should be reviewable 👌

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Sep 20, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Sep 20, 2023
@nelsonic
Copy link
Member

Didn't get the notification for this. Is this reviewable? 💭

image

@LuchoTurtle LuchoTurtle marked this pull request as ready for review September 27, 2023 08:09
@LuchoTurtle LuchoTurtle marked this pull request as draft September 27, 2023 08:10
@LuchoTurtle LuchoTurtle marked this pull request as ready for review September 27, 2023 08:43
@LuchoTurtle
Copy link
Member Author

It should be 👌 . Again, it's connected to my own fork whilst my PRs aren't yet merged in the original repo.
I've included the changes in the merged PR #9 so it doesn't clash.

Should be good to go. WHen the PRs are merged, we can make the changes on a separate PR 👍

@nelsonic
Copy link
Member

@LuchoTurtle please transfer the fork to @dwyl so that other people can contribute to it.
If we end up having to run our own editor project because the upstream are not merging our PRs then so be it.

@LuchoTurtle
Copy link
Member Author

Let me transfer and make the needed changes, then.

@LuchoTurtle LuchoTurtle assigned LuchoTurtle and unassigned nelsonic Sep 27, 2023
@LuchoTurtle LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Sep 27, 2023
>
> We will use a **fork of `visual-editor`** - https://github.com/LuchoTurtle/visual-editor in this guide.
> This is because the PR that was opened to `visual-editor` has need yet been merged
> (https://github.com/visual-space/visual-editor/pull/237).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR(s) you open to visual-editor are not being merged after weeks of waiting
and they are legitimately valid enhancements then it could be time to:
a) consider other options
b) use the fork for the foreseable future and forget the PRs which will bit-rot ...

nelsonic
nelsonic previously approved these changes Sep 27, 2023
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle 👍
Please transfer the fork of visual-editor to @dwyl
so that other people can contribute.

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Sep 27, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Sep 27, 2023
@LuchoTurtle
Copy link
Member Author

You may merge now.
I've renamed the folder to alt_visual_editor so people who run flutter run instead from VSCode won't have problems with the naming of the file.

All instances of the old fork have been changed and the repo has been transferred -> https://github.com/dwyl/visual-editor

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle 🙏

@nelsonic nelsonic merged commit 9be0f16 into main Sep 27, 2023
@nelsonic nelsonic deleted the migrate_to_visual_editor#3 branch September 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Chore: Replace flutter-quill with visual-editor

2 participants