-
Couldn't load subscription status.
- Fork 37
Use curl as optional client #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t overwritten on the stack
|
As a note, I did give this some minor testing, I found a difference in behaviour while doing: that would return an empty Also, currently switching the setting is basically untested. |
f1417a9 to
401ff6b
Compare
This was referenced Jul 3, 2025
Draft
|
superseded by #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates #58 AND #76, since they have some interactions that needed some care.
After duckdb/duckdb#18107 landed in duckdb/duckdb, and moving the
duckdbsubmodule to a recent commit onv1.3-ossivalis, this PR allows to switch at runtime based on the newly addedhttpfsconfig optionhttpfs_client_implementation:It can be checked from the headers that slightly different implementations are used, given for example different styling for
Etagvsetagor similar implementation details.Please check original PR from @Tmonster that all relevant details: #58, this PR only adds a setting and resolve conflict with ongoing work.
Probably best path is cherry-picking commit back into original PR, or anyhow to be discussed on a side.