Wasm HTTPUtil on main #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
force-pushed
the
wasm_httputil_on_main
branch
from
af36634 to
a2cc411
Compare
Collaborator
Author
|
This is ready to be merged on my side |
Mytherin
reviewed
Jul 3, 2025
| SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR} | ||
| INCLUDE_DIR ${CMAKE_CURRENT_LIST_DIR}/extension/httpfs/include | ||
| ${LOAD_HTTPFS_TESTS} | ||
| LINKED_LIBS "../../third_party/mbedtls/libduckdb_mbedtls.a" |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, yes, I have not found a clean way to clean this up.
It should picked up from CMake, but that requires some changes in duckdb/duckdb that are not there (and unsure if they can land today).
Collaborator
Author
There was a problem hiding this comment.
I can fix this up, question is: it's a blocker?
Contributor
There was a problem hiding this comment.
I don't know what problems it causes but it seems hacky - maybe it's fine. I'll leave it up to you
Collaborator
Author
There was a problem hiding this comment.
It does smell badly, you are right, now triggered to find the actual fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not super pretty, since I have not found a more proper way to feature detect HTTPFSClient than
#ifdef's onEMSCRIPTENbeing defined.Weakest part of this PR are the changes in extension/httpfs/httpfs_client.cpp, open to suggestions.
EDIT: I did changed approach, and skip the file at the CMake level
After this PR
httpfsis re-enabled for all platforms.