Skip to content

Fix webSocket not closed in onClosing #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix webSocket not closed in onClosing #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/kotlin/org/phoenixframework/Transport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class WebSocketTransport(

override fun onClosing(webSocket: WebSocket, code: Int, reason: String) {
this.readyState = Transport.ReadyState.CLOSING
webSocket.close(code, reason)
Copy link
Owner

@dsrees dsrees Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also modify the WebSocketTransportTest to include this please?

    internal fun `sets ready state to CLOSING`() {
      ...

      transport.onClosing(mockWebSocket, 10, "reason")
      verify(mockWebSocket).close(10, "reason")
      ...
    }

}

override fun onMessage(webSocket: WebSocket, text: String) {
Expand All @@ -165,4 +166,4 @@ class WebSocketTransport(
this.readyState = Transport.ReadyState.CLOSED
this.onClose?.invoke(code)
}
}
}