Fix webSocket not closed in onClosing #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside Android's Okhttp onClosing callback, we need to manually close the websocket, in order to trigger a reconnect. square/okhttp#3386
dsrees
requested changes
Sep 22, 2022
|
|
||
| override fun onClosing(webSocket: WebSocket, code: Int, reason: String) { | ||
| this.readyState = Transport.ReadyState.CLOSING | ||
| webSocket.close(code, reason) |
There was a problem hiding this comment.
Could you please also modify the WebSocketTransportTest to include this please?
internal fun `sets ready state to CLOSING`() {
...
transport.onClosing(mockWebSocket, 10, "reason")
verify(mockWebSocket).close(10, "reason")
...
}
andrews-moc
added a commit
to salemove/JavaPhoenixClient
that referenced
this pull request
Aug 2, 2023
This is the same as dsrees#90 but with unit test update
Closed
andrews-moc
added a commit
to salemove/JavaPhoenixClient
that referenced
this pull request
Aug 2, 2023
This is the same as dsrees#90 but with unit test update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside Android's Okhttp onClosing callback, we need to manually close the websocket, in order to trigger a reconnect. square/okhttp#3386