Skip to content

feat: Add ARIA roles and attributes #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
May 3, 2019
Merged

feat: Add ARIA roles and attributes #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
bf94e8d
feat: Add aria roles and attributes
gazab Apr 2, 2019
82f945f
test: Update test snapshots
Apr 2, 2019
316f46c
Merge branch 'develop' into feat/aria_tags
mrchief Apr 2, 2019
e040d36
Merge branch 'develop' into feat/aria_tags
ellinge Apr 3, 2019
c21b01b
refactor: Change ARIA attribute generation
Apr 3, 2019
86aa2f5
test: Update tests and snapshots
Apr 3, 2019
36c317a
Merge branch 'feat/aria_tags' of https://github.com/gazab/react-dropd…
Apr 3, 2019
b162545
fix: Fix code style issues
Apr 3, 2019
947efd3
feat: Open dropdown with keyboard
Apr 4, 2019
19ffb72
fix: Correct tree-node aria attributes
Apr 4, 2019
2c95e73
fix: Focus on click also
ellinge Apr 4, 2019
d510a12
fix: Update snapshots
ellinge Apr 4, 2019
c39c8ed
fix: Only prevent default if open with space
ellinge Apr 4, 2019
47f9950
fix: Avoid trigger unless main focus
ellinge Apr 4, 2019
7496e5a
fix: Separate attribute
ellinge Apr 4, 2019
c784a7c
fix: Attribute aria-readonly not allowed on roles
ellinge Apr 5, 2019
b9b87a2
fix: Avoid react warning, bool on event
ellinge Apr 5, 2019
b3eaf97
fix: Handle partial/mixed
ellinge Apr 5, 2019
faa6d73
Merge branch 'develop' into feat/aria_tags
mrchief Apr 14, 2019
e1a8555
fix: Prettier autofixes
ellinge Apr 14, 2019
a19d1f2
fix: Aria-level error
ellinge Apr 17, 2019
a3123c3
fix: Use string to ensure attributes are written
ellinge Apr 17, 2019
acc0815
fix: Only set explicit for aria-expanded
ellinge Apr 17, 2019
871db47
fix: Snapshots
ellinge Apr 17, 2019
0c3dfe5
Merge devlop into 'feat/aria_tags'
ellinge Apr 18, 2019
0191aa3
fix: Explicit aria-expanded
ellinge Apr 20, 2019
57ee7ec
Merge branch 'develop' into feat/aria_tags
ellinge Apr 23, 2019
3e226a3
Merge branch develop into feat/aria_tags
ellinge Apr 27, 2019
cdcdfb3
Merge branch 'feat/aria_tags' of https://github.com/gazab/react-dropd…
ellinge Apr 27, 2019
97f5dec
Merge remote-tracking branch 'upstream/develop' into feat/aria_tags
mrchief May 1, 2019
d505263
chore: Post merge fixes to update snapshots
mrchief May 1, 2019
1c5ae2c
chore: Fix bad merge
mrchief May 1, 2019
3b6a5ea
refactor: Remove extraneous branches
mrchief May 1, 2019
4203a0e
refactor: Consolidate aria attribute gathering
mrchief May 1, 2019
4c62523
chore: Add trailing newline
mrchief May 1, 2019
2b805de
fix: Separate out trigger
ellinge May 1, 2019
0a89cd3
fix: Add comment for removing hash
ellinge May 1, 2019
11b8ce7
fix: Raise duplicate threshold
ellinge May 1, 2019
6ece934
fix: Expand on comment for hash replacement
May 2, 2019
791ff75
fix: Expand on comment for hash replacement
May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ plugins:
config:
languages:
javascript:
mass_threshold : 50
mass_threshold : 60
exclude_patterns:
- "docs/"
- "snapshots/"
Expand Down
158 changes: 91 additions & 67 deletions __snapshots__/src/index.test.js.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ Generated by [AVA](https://ava.li).
<div
className="dropdown"
>
<a
className="dropdown-trigger arrow top"
onClick={Function {}}
<Trigger
onTrigger={Function {}}
showDropdown={true}
>
<Input
inputRef={Function inputRef {}}
Expand All @@ -28,7 +28,7 @@ Generated by [AVA](https://ava.li).
onTagRemove={Function {}}
tags={[]}
/>
</a>
</Trigger>
<div
className="dropdown-content"
>
Expand Down Expand Up @@ -166,8 +166,10 @@ Generated by [AVA](https://ava.li).
<div
className="dropdown"
>
<a
className="dropdown-trigger arrow disabled bottom"
<Trigger
disabled={true}
onTrigger={Function {}}
showDropdown={false}
>
<Input
disabled={true}
Expand All @@ -179,7 +181,7 @@ Generated by [AVA](https://ava.li).
onTagRemove={Function {}}
tags={[]}
/>
</a>
</Trigger>
</div>
</div>

Expand Down Expand Up @@ -263,39 +265,51 @@ Generated by [AVA](https://ava.li).
<div
className="dropdown radio-select"
>
<a
className="dropdown-trigger arrow bottom"
onClick={Function {}}
<Trigger
onTrigger={Function {}}
radioSelect={true}
showDropdown={false}
>
<Input
inputRef={Function inputRef {}}
onBlur={Function {}}
onFocus={Function {}}
onInputChange={Function {}}
<a
"aria-expanded"="false"
"aria-haspopup"="tree"
className="dropdown-trigger arrow bottom"
onClick={Function {}}
onKeyDown={Function {}}
onTagRemove={Function {}}
tags={[]}
role="button"
tabIndex={0}
>
<ul
className="tag-list"
<Input
inputRef={Function inputRef {}}
onBlur={Function {}}
onFocus={Function {}}
onInputChange={Function {}}
onKeyDown={Function {}}
onTagRemove={Function {}}
radioSelect={true}
tags={[]}
>
<li
className="tag-item"
<ul
className="tag-list"
>
<input
"aria-autocomplete"="list"
className="search"
onBlur={Function {}}
onChange={Function {}}
onFocus={Function {}}
onKeyDown={Function {}}
placeholder="Choose..."
type="text"
/>
</li>
</ul>
</Input>
</a>
<li
className="tag-item"
>
<input
"aria-autocomplete"="list"
className="search"
onBlur={Function {}}
onChange={Function {}}
onFocus={Function {}}
onKeyDown={Function {}}
placeholder="Choose..."
type="text"
/>
</li>
</ul>
</Input>
</a>
</Trigger>
</div>
</div>
</DropdownTreeSelect>
Expand Down Expand Up @@ -379,39 +393,49 @@ Generated by [AVA](https://ava.li).
<div
className="dropdown"
>
<a
className="dropdown-trigger arrow bottom"
onClick={Function {}}
<Trigger
onTrigger={Function {}}
showDropdown={false}
>
<Input
inputRef={Function inputRef {}}
onBlur={Function {}}
onFocus={Function {}}
onInputChange={Function {}}
<a
"aria-expanded"="false"
"aria-haspopup"="tree"
className="dropdown-trigger arrow bottom"
onClick={Function {}}
onKeyDown={Function {}}
onTagRemove={Function {}}
tags={[]}
role="button"
tabIndex={0}
>
<ul
className="tag-list"
<Input
inputRef={Function inputRef {}}
onBlur={Function {}}
onFocus={Function {}}
onInputChange={Function {}}
onKeyDown={Function {}}
onTagRemove={Function {}}
tags={[]}
>
<li
className="tag-item"
<ul
className="tag-list"
>
<input
"aria-autocomplete"="list"
className="search"
onBlur={Function {}}
onChange={Function {}}
onFocus={Function {}}
onKeyDown={Function {}}
placeholder="Choose..."
type="text"
/>
</li>
</ul>
</Input>
</a>
<li
className="tag-item"
>
<input
"aria-autocomplete"="list"
className="search"
onBlur={Function {}}
onChange={Function {}}
onFocus={Function {}}
onKeyDown={Function {}}
placeholder="Choose..."
type="text"
/>
</li>
</ul>
</Input>
</a>
</Trigger>
</div>
</div>
</DropdownTreeSelect>
Expand All @@ -427,9 +451,9 @@ Generated by [AVA](https://ava.li).
<div
className="dropdown"
>
<a
className="dropdown-trigger arrow top"
onClick={Function {}}
<Trigger
onTrigger={Function {}}
showDropdown={true}
>
<Input
inputRef={Function inputRef {}}
Expand All @@ -440,7 +464,7 @@ Generated by [AVA](https://ava.li).
onTagRemove={Function {}}
tags={[]}
/>
</a>
</Trigger>
<div
className="dropdown-content"
>
Expand Down
Binary file modified __snapshots__/src/index.test.js.snap
View file
Open in desktop
Binary file not shown.
Loading