feat: Add ARIA roles and attributes #233

gazab · 2019-04-02T10:43:48Z

What does it do?

Adds some ARIA roles and attributes according to:

Does not add label to input element because #225 already solves that.

Fixes # (issue)

Partly addresses #216

Type of change

New feature (non-breaking change which adds functionality)

coveralls · 2019-04-02T10:49:09Z

Pull Request Test Coverage Report for Build 1110

37 of 38 (97.37%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 94.486%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/trigger/index.js	14	15	93.33%

Totals
Change from base Build 1100:	-0.09%
Covered Lines:	564
Relevant Lines:	579

💛 - Coveralls

__snapshots__/src/index.test.js.md

src/tree-node/index.test.js

mrchief · 2019-04-02T19:48:27Z

This is great! Thanks for sending this!

src/index.js

src/tree-node/index.js

src/tree/index.js

…own-tree-select into feat/aria_tags

src/tree/index.js

src/tree-node/index.js

mrchief · 2019-04-05T20:49:45Z

aria-hidden seems incorrect here as this is not hidden content. Also, I think we should add aria-expanded here as it marks collapsible content.

mrchief · 2019-04-05T20:52:30Z

The root should be level 0, instead it's level 1

mrchief · 2019-04-24T03:50:36Z

Don't bother resolving the intermediate conflicts. We can do a final resolving when this PR is about to be merged. Same goes for 230, 242

…own-tree-select into feat/aria_tags

# Conflicts: # __snapshots__/src/index.test.js.md # __snapshots__/src/index.test.js.snap # __snapshots__/src/tree-node/index.test.js.md # __snapshots__/src/tree-node/index.test.js.snap # src/index.js # src/index.test.js # src/tree-node/index.js

src/a11y/index.js

mrchief · 2019-05-01T00:56:23Z

Need to figure out a way to resolve the codeclimate complexity error. I think CC is right here. Gonna take a shot with fresh mind tomorrow. Feel free to propose any ideas you may have.

src/trigger/index.js

src/index.js

ellinge · 2019-05-01T22:54:16Z

Separated out the trigger to a separate js. Two large methods which could be moved as well.

src/index.js

qlty-cloud-legacy · 2019-05-02T07:45:34Z

Code Climate has analyzed commit 791ff75 and detected 0 issues on this pull request.

View more on Code Climate.

mrchief

👍

Fixes #235 Fixes #216

mrchief · 2019-05-04T20:08:16Z

@allcontributors[bot] Let's add @gazab for code

allcontributors · 2019-05-04T20:08:23Z

@mrchief

I've put up a pull request to add @gazab! 🎉

mrchief · 2019-06-10T23:04:21Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

gazab and others added 2 commits April 2, 2019 09:12

feat: Add aria roles and attributes

bf94e8d

test: Update test snapshots

82f945f

gazab changed the title ~~Accessibility: Add ARIA roles and attributes~~ feat: Add ARIA roles and attributes Apr 2, 2019

mrchief reviewed Apr 2, 2019

View reviewed changes

__snapshots__/src/index.test.js.md Outdated Show resolved Hide resolved

mrchief reviewed Apr 2, 2019

View reviewed changes

src/tree-node/index.test.js Outdated Show resolved Hide resolved

Merge branch 'develop' into feat/aria_tags

316f46c

Merge branch 'develop' into feat/aria_tags

e040d36

ellinge reviewed Apr 3, 2019

View reviewed changes

src/index.js Outdated Show resolved Hide resolved

ellinge reviewed Apr 3, 2019

View reviewed changes

src/tree-node/index.js Outdated Show resolved Hide resolved

ellinge reviewed Apr 3, 2019

View reviewed changes

src/tree/index.js Outdated Show resolved Hide resolved

Gustav Tonér added 3 commits April 3, 2019 10:22

refactor: Change ARIA attribute generation

c21b01b

test: Update tests and snapshots

86aa2f5

Merge branch 'feat/aria_tags' of https://github.com/gazab/react-dropd…

36c317a

…own-tree-select into feat/aria_tags

qlty-cloud-legacy bot reviewed Apr 3, 2019

View reviewed changes

fix: Fix code style issues

b162545

ellinge reviewed Apr 3, 2019

View reviewed changes

src/tree-node/index.js Outdated Show resolved Hide resolved

ellinge mentioned this pull request Apr 4, 2019

feat: Add keyboard navigation #225

Merged

1 task

Gustav Tonér and others added 9 commits April 4, 2019 12:53

feat: Open dropdown with keyboard

947efd3

fix: Correct tree-node aria attributes

19ffb72

fix: Focus on click also

2c95e73

fix: Update snapshots

d510a12

fix: Only prevent default if open with space

c39c8ed

fix: Avoid trigger unless main focus

47f9950

fix: Separate attribute

7496e5a

fix: Attribute aria-readonly not allowed on roles

c784a7c

fix: Avoid react warning, bool on event

b9b87a2

ellinge and others added 2 commits April 20, 2019 15:22

fix: Explicit aria-expanded

0191aa3

Merge branch 'develop' into feat/aria_tags

57ee7ec

ellinge and others added 8 commits April 27, 2019 22:24

Merge branch develop into feat/aria_tags

3e226a3

Merge branch 'feat/aria_tags' of https://github.com/gazab/react-dropd…

cdcdfb3

…own-tree-select into feat/aria_tags

chore: Post merge fixes to update snapshots

d505263

chore: Fix bad merge

1c5ae2c

refactor: Remove extraneous branches

3b6a5ea

refactor: Consolidate aria attribute gathering

4203a0e

chore: Add trailing newline

4c62523

mrchief reviewed May 1, 2019

View reviewed changes

src/a11y/index.js Show resolved Hide resolved

ellinge added 2 commits May 2, 2019 00:49

fix: Separate out trigger

2b805de

fix: Add comment for removing hash

0a89cd3

qlty-cloud-legacy bot reviewed May 1, 2019

View reviewed changes

src/trigger/index.js Show resolved Hide resolved

src/index.js Show resolved Hide resolved

fix: Raise duplicate threshold

11b8ce7

mrchief reviewed May 1, 2019

View reviewed changes

src/index.js Show resolved Hide resolved

Magnus Ellinge added 2 commits May 2, 2019 09:41

fix: Expand on comment for hash replacement

6ece934

fix: Expand on comment for hash replacement

791ff75

mrchief approved these changes May 3, 2019

View reviewed changes

mrchief merged commit 7133ed2 into dowjones:develop May 3, 2019

mrchief pushed a commit that referenced this pull request May 3, 2019

feat: Add ARIA roles and attributes (#233)

3e5381e

Fixes #235 Fixes #216

allcontributors bot mentioned this pull request May 4, 2019

docs: add gazab as a contributor #247

Merged

mrchief added the released label Jun 10, 2019

feat: Add ARIA roles and attributes #233

feat: Add ARIA roles and attributes #233

Uh oh!

Conversation

gazab commented Apr 2, 2019 • edited by mrchief Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does it do?

Fixes # (issue)

Type of change

Uh oh!

coveralls commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 1110

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

mrchief commented Apr 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrchief commented Apr 5, 2019

Uh oh!

mrchief commented Apr 5, 2019

Uh oh!

mrchief commented Apr 24, 2019

Uh oh!

Uh oh!

mrchief commented May 1, 2019

Uh oh!

Uh oh!

Uh oh!

ellinge commented May 1, 2019

Uh oh!

Uh oh!

qlty-cloud-legacy bot commented May 2, 2019

Uh oh!

mrchief left a comment

Choose a reason for hiding this comment

Uh oh!

mrchief commented May 4, 2019

Uh oh!

allcontributors bot commented May 4, 2019

Uh oh!

mrchief commented Jun 10, 2019

Uh oh!

Uh oh!

gazab commented Apr 2, 2019 •

edited by mrchief

Loading

coveralls commented Apr 2, 2019 •

edited

Loading