Removed declarative CAS permission attributes and comments #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
Member
|
vatsan-madhavan
requested changes
Jun 18, 2019
Member
vatsan-madhavan
left a comment
vatsan-madhavan
left a comment
There was a problem hiding this comment.
Would you mind listing the types that are part of your candidate list for removal?
Member
|
Pesentationcore, System.Xaml look good. |
Member
|
The changes look good. Definitely requires another round of changes to complete the work, but I see no reason to block merging this. |
vatsan-madhavan
approved these changes
Jun 18, 2019
Author
Talked offline, adding list here for posterity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Issue #241
Another PR upcoming to complete the rest of the attribute removal