Remove SecurityCriticalDataForMultipleGetAndSet #6342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Member
|
We have taken this PR for the current Community Test Pass. Thanks for the contribution. |
ThomasGoulet73
deleted the
remove-securitycriticaldataformultiplegetandset
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes SecurityCriticalDataForMultipleGetAndSet which is unused since the removal of CAS attributes in #994.
Removes these 2 allocations from an empty new WPF application:
Customer Impact
Removes unnecessary allocations.
Regression
No.
Testing
Tested locally + CI.
Risk
Low.