Set correct assembly version for IdentityModel assemblies #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Aug 1, 2023
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
Thoughts on backporting this or at least opening an issue to support building in a non-windows environment? The best approach may be to make this msbuild logic rather than a script.
Member
Author
|
I've submitted a PR to get this backported at AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2211. |
MichaelSimons
approved these changes
Aug 8, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default IdentityModel assemblies have a version of 0.0.1, which is the default version specified in the azure-activedirectory-identitymodel-extensions-for-dotnet repo. This differs from the Microsoft-produced versions of these assemblies that the SDK contains, which has an assembly version of 7.0.0.
This is fixed by explicitly updating the AssemblyInfo.cs file of each source project in the repo to have the desired version attributes. There's already an existing PowerShell script which does this. However, that script can't be executed in the context of source-build because it relies on PowerShell which is not source-buildable. Instead, that script has been ported to Bash.
Fixes dotnet/source-build#3565