Remove IdentityModel assemblies from assembly version diff baseline #17169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (Process Process, string StdOut, string StdErr) diffResult = | ||
| ExecuteHelper.ExecuteProcess("git", $"diff --no-index {file1Path} {file2Path}", outputHelper); | ||
| Assert.Equal(1, diffResult.Process.ExitCode); | ||
| Assert.True(diffResult.Process.ExitCode == 0 || diffResult.Process.ExitCode == 1); |
Member
There was a problem hiding this comment.
Does it make sense to retain this Assert anymore? It looks like the exit code from git diff is either 0 or 1.
Member
Author
There was a problem hiding this comment.
Yeah probably not. It looks like other error conditions return 1 as well so this doesn't add any value.
MichaelSimons
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dotnet/source-build-externals#179 has been integrated, the SB SDK diff tests are failing because the assembly versions are now correct. This causes there to be no diff between the MSFT and SB SDKs for assembly versions.
The test infra has been updated to allow for a call to
git diffto return a0exit code, meaning no diffs. And the baseline file is also updated to no longer contain the IdentityModel assemblies as diffs.The SDK diff test pipeline won't yet pass completely with this change. It's still failing in the Ubuntu legs because the VMR doesn't yet have passing build jobs for that distro. That won't happen until dotnet/source-build-externals#183 is integrated.