ensure that all TargetFrameworkEval properties are sent without any m… #50930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an-in-the-middle blocking
dsplaisted
approved these changes
Sep 22, 2025
baronfel
commented
Sep 22, 2025
| <TFTelemetry Include="PublishProtocol" Value="$(PublishProtocol)" /> | ||
| <TFTelemetry Include="Configuration" Value="$(Configuration)" /> | ||
| <TFTelemetry Include="PublishProtocol" Value="$(PublishProtocol)" /> | ||
| <TFTelemetry Include="Configuration" Value="$(Configuration)" Hash="true" /> |
There was a problem hiding this comment.
After talking to Daniel, we should:
- change the default of AllowEmptyTelemetry so that values are hashed by default and require explicit opt out (so we can be safe)
- audit and annotate all of the existing usage of AllowEmptyTelemetry to align with this new default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50561 we sent new properties on TargetFrameworkEval, but we didn't allowlist them through the MSBuildLogger so we never saw the new properties.
The allowlisting inside the MSBuildLogger was done before the AllowEmptyTelemetry Task had the
Hashmetadata, so by moving to that we can remove any special handling inside the MSBuildLogger itself and more easily audit the telemetry data configuration.