-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add more properties to targetframeworkeval
telemetry event
#50561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more properties to targetframeworkeval
telemetry event
#50561
Conversation
This PR is targeting |
Triage/proposal:
|
7c601fd
to
cb3a23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds mobile telemetry collection for the Build
target that captures platform-specific properties for Android, iOS, macCatalyst, and tvOS builds. The telemetry collects properties like target platform identifier, runtime identifier, mono runtime usage, and AOT/ReadyToRun configurations.
- Extends existing target framework telemetry to include mobile-specific properties
- Updates test expectations to include the new telemetry properties in assertions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreAppForTelemetry.cs | Updates test assertions to include new mobile telemetry properties in expected output |
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets | Adds three new telemetry properties for mobile builds: TargetPlatformIdentifier, UseMonoRuntime, and PublishAot |
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets
Show resolved
Hide resolved
Build
targettargetframeworkeval
telemetry event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but have a request for a few more properties so we can be ready to deprecate the PublishProperties event in the future.
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets
Show resolved
Hide resolved
…etFrameworkInference.targets Co-authored-by: Chet Husk <[email protected]>
targetframeworkeval
telemetry eventtargetframeworkeval
telemetry event
Note that this PR is targeting main. We'll either need to retarget it to release/10.0.1xx, or merge it to main and then backport. Any preference? @matouskozak @baronfel |
Since it's already green on this branch I'd just backport, to save more CI cycles |
/backport to release/10.0.1xx |
Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17676204640 |
I added the documentation label as a marker that we have some work to do here before GA. most properties are already documented, we just need the new ones. |
Description
Adding properties (
TargetPlatformIdentifier
,UseMonoRuntime
,PublishAot
,Configuration
) needed for mobile-related telemetry tracking totargetframeworkeval
event.Additionally, adding more publish-related (
PublishTrimmed
,PublishSelfContained
,PublishReadyToRun
,PublishReadyToRunComposite
,PublishProtocol
) properties to maketargetframeworkeval
the center piece for property tracking.Sample Output Telemetry
Testing
Tested locally by installing
android
workload to.dotnet/dotnet
and running the following tests:Publish:
Build:
Another testing was done by locally modified version of SDK, where I modified the .target files and verified that the mobile telemetry targets get executed for
dotnet new android
app.Future Work
SessionId
that allows pairingtargetframeworkeval
events withbuild
/publish
and other .NET CLI commands.