Skip to content

[dotnet-watch] Improve failure reporting in tests #44879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[dotnet-watch] Improve failure reporting in tests #44879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,6 @@ void FileChangedCallback(string path, ChangeKind kind)
{
ImmutableInterlocked.Update(ref changedFilesAccumulator, changedFiles => changedFiles.Add(changedFile));
}
else
{
Context.Reporter.Verbose($"Change ignored: {kind} '{path}'.");
}
}

fileChangedCallback = FileChangedCallback;
Expand Down Expand Up @@ -454,6 +450,11 @@ async Task<ImmutableList<ChangedFile>> CaptureChangedFilesSnapshot(ImmutableDict
{
// start next iteration unless shutdown is requested
}
catch (Exception) when ((waitForFileChangeBeforeRestarting = false) == true)
{
// unreachable
throw new InvalidOperationException();
}
finally
{
// stop watching file changes:
Expand Down Expand Up @@ -598,6 +599,7 @@ private async ValueTask WaitForFileChangeBeforeRestarting(FileWatcher fileWatche
return new ChangedFile(new FileItem { FilePath = path, ContainingProjectPaths = [] }, kind);
}

Context.Reporter.Verbose($"Change ignored: {kind} '{path}'.");
return null;
}

Expand Down
Loading
Loading