Skip to content

Conversation

@tmat
Copy link
Member

@tmat tmat commented Nov 14, 2024

Factor common test initialization code to a helper.
Trigger cancellation on unexpected exceptions to avoid hanging.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Nov 14, 2024
@tmat tmat changed the title Update roslyn [donet-watch] @tmat Update to new Roslyn APIs Nov 14, 2024
@tmat tmat changed the title [donet-watch] @tmat Update to new Roslyn APIs [donet-watch] Update to new Roslyn APIs Nov 14, 2024
@tmat tmat changed the title [donet-watch] Update to new Roslyn APIs [dotnet-watch] Improve failure reporting in tests Nov 25, 2024
@tmat tmat marked this pull request as ready for review November 25, 2024 16:40
@tmat tmat requested a review from a team as a code owner November 25, 2024 16:40
@tmat
Copy link
Member Author

tmat commented Nov 25, 2024

@phil-allen-msft

@nagilson
Copy link
Member

@tmat Thank you for this PR, it looks like some watch tests are still failing -- may you PTAL?

@nagilson
Copy link
Member

nagilson commented Dec 2, 2024

@tmat What's left to do here?

@dsplaisted
Copy link
Member

@tmat Can you take a look at this and see what is needed to get it working? It sounds like this PR is supposed to unblock #44874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants