Correct emsdk Version.Details.xml sha #37305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
|
@MichaelSimons Should this target 8.0.2xx? 8.0.1xx flows internally, with a new version of emsdk already. Changing it in 8.0.1xx here would have no effect except to generate merge conflicts. |
Member
At the point that pr landed there wasn't a final 8.0.0 sha so it wasn't entirely a miss. I'm not sure why it didn't update with other stable build flow though. |
MichaelSimons
force-pushed
the
fix-emsdk-sha
branch
from
8905455 to
ce33ccf
Compare
MichaelSimons
changed the base branch from
release/8.0.1xx
to
release/8.0.2xx
Member
Author
Done |
mmitche
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emsdk Version.Details.xml dependency is incoherent in that the version and sha do not match. This messes up source-build when flowed into installer (see dotnet/installer#17695). I have updated the sha to match the version.
This was introduced in #36340. (Sorry I missed it in review)