Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Oct 21, 2023

Updated variant of #35569 with the proper darc feed, the dependency is incoherent until #33126 lands but correct

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 21, 2023
@lewing
Copy link
Member Author

lewing commented Oct 22, 2023

@dotnet/source-build-internal please take a look at the failure here

@lewing
Copy link
Member Author

lewing commented Oct 22, 2023

same issue as dotnet/runtime#93801

  • darc needs stable package names.
  • sdk wants the workload package names to change for each version band
  • with stable versions the shipping pacakages go to 8.0.0 but the transport packages didn't (I just realized this could be a problem with emsdk version logic but I don't think so?)
  • and source build breaks when you satisfy darc by changing the package name in the dependency

At the moment emsdk doesn't have a shipping package that can satisfy those requirements simultaneously, we used a transport package just for the darc flow but that breaks with stable versions so this pr switches to the stable packages name but that breaks sourcebuild and I don't know how to resolve the source build chain myself.

@lewing lewing changed the title Fix emsdk dep for stable version [release/8.0] Fix emsdk dep for stable version Oct 22, 2023
@MichaelSimons
Copy link
Member

If source-build isn't flagging this as a prebuilt, I think it is correct to drop the source-build adornment from the dependency. If it were reported as a prebuilt then adding a dependency on the intermediate as done in https://github.com/dotnet/runtime/pull/93801/files/be0554c70b9444795ac78c5f617bcddce0b922e6..8c1faf561b8a305661cda047cf0298250a0c919a would be the correct was to resolve this.

@lewing lewing merged commit 11c63d6 into release/8.0.1xx Oct 23, 2023
@lewing lewing deleted the fix-emsdk-for-stable-version branch October 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants