Make non-portable RID warning check all available NETCore.App RIDS for the current TFM #33584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the current TFM
ghost
added
This was referenced Jun 26, 2023
halter73
approved these changes
Jun 27, 2023
dsplaisted
approved these changes
Jun 27, 2023
|
Where can I find the SDK version that I need to reference in global.json? The dotnet/installer only shows Preview5 and Preview7 packages. [EDIT] found it here --> 8.0.100-preview.6.23326.6 |
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding NETSDK1206 (#32970), I only added the RID platforms for the selected Microsoft.NETCore.App pack to the list of known platforms. This meant that if an app was built for coreclr referencing a package with RID-specific assets that only have corresponding mono packs (for example, browser), the warning would be fired. We want to include the platforms for all the Microsoft.NETCore.App packs for the current target framework, not just the ones with a matching label.
This is targeting Preview 6.
Fixes #33579