Better fix for the OSX issues in installer repo #30573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nagilson
approved these changes
Feb 14, 2023
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
Approved, thank you for adding the comment mapping SDK versions to OSX versions
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #29916 as this is causing linux failures in installer now
Port fix for environmentinfo.
Realize that the fix won't work for 11.0
Modify the fix to work better following the idea of the other fix that almost worked
#29916
#29083
I manually tested various combinations of 10.12, 10.14, 10.15, 11.0, and 12