Fix unhandled exception during test discovery on macOS #29083
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| string osxVersionString = restOfRid.Split('-')[0]; | ||
|
|
||
| // Starting with macOS 12.0 (Monterey), the RID is "osx.12-x64" instead of the "osx.10.14-x64" format used before, so the version won't have a dot in it | ||
| if (!osxVersionString.Contains('.')) |
There was a problem hiding this comment.
Instead of relying on the fact that the RID doesn't contain a period in it, could we make the OS parsing resilient to not having a dot? Then this condition would be something like macOSMajorVersion >= 12.
There was a problem hiding this comment.
@dsplaisted good point, I switched to using float parsing for the version like we do for Ubuntu.
akoeplinger
force-pushed
the
fix-unhandled-exception
branch
from
a529203 to
145c8e8
Compare
|
@akoeplinger I'm not sure float parsing is a good idea here either, since floats can't represent decimals exactly and you might get a result something like 16.0400000000001. I was going to suggest something like |
|
@dsplaisted I tried and |
|
besides that, 10.12 is ancient so we could probably get rid of that specific version check :) |
While debugging dotnet#29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
akoeplinger
force-pushed
the
fix-unhandled-exception
branch
from
145c8e8 to
77c0980
Compare
2 participants
While debugging #29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed.
Switched to using float parsing for the version like we do for Ubuntu.