Skip to content

Internal.Console.Write uses unicode encoding for iOS #78974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Internal.Console.Write uses unicode encoding for iOS #78974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a9159d
Internal.Console.Write uses unicode encoding for iOS
kotlarmilos Nov 29, 2022
280c2fb
use Internal/Console.iOS.cs for IsiOSLike
kotlarmilos Nov 29, 2022
bfa82af
string to byte*
kotlarmilos Nov 29, 2022
083c3d0
add LogError
kotlarmilos Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/libraries/System.Private.CoreLib/src/Internal/Console.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Text;

namespace Internal
{
public static partial class Console
{
public static unsafe void Write(string s)
{
fixed (char* ptr = s)
{
Interop.Sys.Log((byte*)ptr, s.Length * 2);
}
}
public static partial class Error
{
public static unsafe void Write(string s)
{
fixed (char* ptr = s)
{
Interop.Sys.LogError((byte*)ptr, s.Length * 2);
}
}
}
}
}
3 changes: 2 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,8 +2235,9 @@
<Compile Include="$(CommonPath)System\IO\PathInternal.Unix.cs">
<Link>Common\System\IO\PathInternal.Unix.cs</Link>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)Internal\Console.Unix.cs" Condition="'$(TargetsAndroid)' != 'true'" />
<Compile Include="$(MSBuildThisFileDirectory)Internal\Console.Unix.cs" Condition="'$(TargetsAndroid)' != 'true' and '$(IsiOSLike)' != 'true'" />
<Compile Include="$(MSBuildThisFileDirectory)Internal\Console.Android.cs" Condition="'$(TargetsAndroid)' == 'true'" />
<Compile Include="$(MSBuildThisFileDirectory)Internal\Console.iOS.cs" Condition="'$(IsiOSLike)' == 'true'" />
<Compile Include="$(CommonPath)Interop\Android\Interop.Logcat.cs" Condition="'$(TargetsAndroid)' == 'true' or '$(TargetsLinuxBionic)' == 'true'">
<Link>Common\Interop\Android\Interop.Logcat.cs</Link>
</Compile>
Expand Down