Internal.Console.Write uses unicode encoding for iOS #78974
Merged
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
kotlarmilos
requested review from
MichalStrehovsky,
akoeplinger and
ivanpovazan
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFix encoding between
|
jkotas
reviewed
Nov 29, 2022
src/libraries/System.Private.CoreLib/src/Internal/Console.iOS.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Nov 29, 2022
campersau
reviewed
Nov 29, 2022
| { | ||
| fixed (char* ptr = s) | ||
| { | ||
| Interop.Sys.Log((byte*)ptr, s.Length * 2); |
There was a problem hiding this comment.
Isn't there a LogError for iOS? Because before this was called, right?
There was a problem hiding this comment.
good catch, yes this should be Interop.Sys.LogError
There was a problem hiding this comment.
Yes, it was accidentally replaced by last commit
|
MacCatalyst failure is #78778 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix encoding between
Internal.Console.WriteandSystemNative_Logfor iOS to beUTF16.