Skip to content

[release/6.0] Source-Build: Remove ILStrip dependency from mono #77503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release/6.0] Source-Build: Remove ILStrip dependency from mono #77503

wants to merge 1 commit into from

Conversation

@ayakael
Copy link
Contributor

@ayakael ayakael commented Oct 26, 2022

Per @omajid: "Mono still has a dependency on (now unbuildable) ILStrip which was removed from CoreCLR"

This was in Fedora's patch list and is now used for building dotnet6 on Alpine Linux.

@ayakael ayakael requested a review from marek-safar as a code owner October 26, 2022 19:18
@ghost ghost added area-Build-mono community-contribution Indicates that the PR has been added by a community member labels Oct 26, 2022
@ayakael ayakael mentioned this pull request Oct 26, 2022
Closed
18 tasks
@ayakael ayakael changed the title [release/6.0] Source-Build: Remove ILStrip depedency from mono [release/6.0] Source-Build: Remove ILStrip dependency from mono Oct 26, 2022
@teo-tsirpanis teo-tsirpanis added this to the 6.0.x milestone Oct 26, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 26, 2022
Closed
@akoeplinger
Copy link
Member

akoeplinger commented Oct 27, 2022

So #61607 wasn't enough?

@omajid
Copy link
Member

omajid commented Oct 27, 2022

@ayakael IIRC, @uweigand and I came up with slightly different fixes for the same issue and they both did effectively the same thing. Uli's PR #61607 was merged into main and then backported to 6.0 as #63701. Maybe this PR isn't needed? Did you try building without it?

@ayakael
Copy link
Contributor Author

ayakael commented Oct 27, 2022

@ayakael IIRC, @uweigand and I came up with slightly different fixes for the same issue and they both did effectively the same thing. Uli's PR #61607 was merged into main and then backported to 6.0 as #63701. Maybe this PR isn't needed? Did you try building without it?

I'll try without.

@ayakael
Copy link
Contributor Author

ayakael commented Oct 29, 2022

Yup, building without this patch works. Sorry for the noise, closing.

@ayakael ayakael closed this Oct 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

No one assigned

Labels

area-Build-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@ayakael @akoeplinger @omajid @teo-tsirpanis