[wasm] Allocate a variable for all ref typed vregs and mark them as v… #51580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olatile. This forces the llvm backend to allocate a stack location for them, so they get GC tracking.
vargaz
requested review from
CoffeeFlux,
SamMonoRT and
lambdageek
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
approved these changes
Apr 20, 2021
|
Hello @lewing! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Member
|
This likely resolves the need for dotnet/aspnetcore#31847 so we should reenable and test. |
lewing
added a commit
to lewing/aspnetcore
that referenced
this pull request
Apr 24, 2021
ghost
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Apr 26, 2021
* Reenable on_demand_gc after dotnet/runtime#51580 * Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts Co-authored-by: Steve Sanderson <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…olatile.
This forces the llvm backend to allocate a stack location for them, so they
get GC tracking.