Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Apr 15, 2021

We enabled on_demand_gc in .NET 6 with #29098. Wasm AOT'd e3e benchmarks are seeing errors that appear to go away with on_demand_gc disabled

dotnet/runtime#51319

Staging this for preview 4 while we work the issue.

@lewing lewing requested a review from a team as a code owner April 15, 2021 19:28
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 15, 2021
@lewing
Copy link
Member Author

lewing commented Apr 15, 2021

Failure is RendersAuthorizingUntilAuthorizationCompletedAsync, it was added in #31794 and unlikely to be related to this change.

@captainsafia
Copy link
Member

cc: @jkotalik for potential flake

@jkotalik
Copy link
Contributor

@HaoK can you tell me if the failure on RendersAuthorizingUntilAuthorizationCompletedAsync is a pressing issue that needs to be fixed? I see the test was just merged this morning.

I'll mark it as quarantined anyways but considering it was a just added test, I want to make sure we didn't merge something that caused a regression.

@jkotalik
Copy link
Contributor

System.InvalidOperationException : Sequence contains more than one element

 at System.Linq.ThrowHelper.ThrowMoreThanOneElementException()
   at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable`1 source, Boolean& found)
   at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
   at Microsoft.AspNetCore.Components.Authorization.AuthorizeViewTest.RendersAuthorizingUntilAuthorizationCompletedAsync() in /_/src/Components/Authorization/test/AuthorizeViewTest.cs:line 318

@HaoK
Copy link
Member

HaoK commented Apr 15, 2021

Yeah it was just added, don't think it will be related

@ghost
Copy link

ghost commented Apr 15, 2021

Hello @captainsafia!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 728c130 into dotnet:main Apr 16, 2021
@lewing lewing deleted the revert-29098 branch April 24, 2021 04:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants