Skip to content

Conversation

@eerhardt
Copy link
Member

I chose the same namespace as ComponentCatalog is in, which is the root Microsoft.ML.Runtime namespace. If we ever move ComponentCatalog to a different namespace, we could move this as well.

I spot checked as many places as I could to remove unnecessary using Microsoft.ML.Runtime.EntryPoints statements.

Fix #861

/// Entry point factory for creating <see cref="IServer"/> instances.
/// </summary>
[TlcModule.ComponentKind("Server")]
public interface IServerFactory : IArgsComponent, IComponentFactory<IChannel, IServer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IArgsComponent [](start = 42, length = 14)

feel free to remove this interface as well. It was temporary introduce for Neural nets entry points almost two years ago, and we no longer need it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed IArgsComponent completely.

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TomFinley
Copy link
Contributor

This sounds good thank you @eerhardt...

One thing that we will want to consider is your suggestion earlier that we get rid of all these specialized subinterfaces and just make things over IComponentFactory directly. (E.g., no IServerFactory, though there would be one of the appropriate IComponentFactory<... The only thing that seems to practically stand in the way is all these [TlcModule.ComponentKind(...)] declarations -- I'm not sure what they're for but I'd wager they have something to do with entry-points. But I wonder if there's another way we could achieve the same effect. Not related to this, just something that came to mind as I looked at it.

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eerhardt !

@eerhardt
Copy link
Member Author

The existing usages of specialized subinterfaces are all in "Entry Points" APIs. My assumption was that we weren't necessarily working on optimizing these APIs.

@TomFinley TomFinley merged commit a8cd341 into dotnet:master Sep 14, 2018
@eerhardt eerhardt deleted the ComponentFactoryNamespace branch November 7, 2018 14:56
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants