-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Move IComponentFactory from EntryPoints namespace #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /// Entry point factory for creating <see cref="IServer"/> instances. | ||
| /// </summary> | ||
| [TlcModule.ComponentKind("Server")] | ||
| public interface IServerFactory : IArgsComponent, IComponentFactory<IChannel, IServer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IArgsComponent [](start = 42, length = 14)
feel free to remove this interface as well. It was temporary introduce for Neural nets entry points almost two years ago, and we no longer need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed IArgsComponent completely.
Ivanidzo4ka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
This sounds good thank you @eerhardt... One thing that we will want to consider is your suggestion earlier that we get rid of all these specialized subinterfaces and just make things over |
TomFinley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eerhardt !
|
The existing usages of specialized subinterfaces are all in "Entry Points" APIs. My assumption was that we weren't necessarily working on optimizing these APIs. |
I chose the same namespace as
ComponentCatalogis in, which is the rootMicrosoft.ML.Runtimenamespace. If we ever moveComponentCatalogto a different namespace, we could move this as well.I spot checked as many places as I could to remove unnecessary
using Microsoft.ML.Runtime.EntryPointsstatements.Fix #861