Skip to content

Commit a8cd341

Browse files
eerhardtTomFinley
authored andcommitted
Move IComponentFactory from EntryPoints namespace (#887)
1 parent 9d583b6 commit a8cd341

File tree

23 files changed

+3
-34
lines changed

23 files changed

+3
-34
lines changed

src/Microsoft.ML.Api/ComponentCreation.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using System.IO;
88
using Microsoft.ML.Runtime.CommandLine;
99
using Microsoft.ML.Runtime.Data;
10-
using Microsoft.ML.Runtime.EntryPoints;
1110
using Microsoft.ML.Runtime.Model;
1211

1312
namespace Microsoft.ML.Runtime.Api

src/Microsoft.ML.Core/EntryPoints/ComponentFactory.cs renamed to src/Microsoft.ML.Core/ComponentModel/ComponentFactory.cs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
using System;
66

7-
namespace Microsoft.ML.Runtime.EntryPoints
7+
namespace Microsoft.ML.Runtime
88
{
99
/// <summary>
1010
/// This is a token interface that all component factories must implement.
@@ -13,14 +13,6 @@ public interface IComponentFactory
1313
{
1414
}
1515

16-
/// <summary>
17-
/// This is a token interface for component classes that don't directly create
18-
/// a runtime component, but only need to represent a polymorphic set of arguments.
19-
/// </summary>
20-
public interface IArgsComponent : IComponentFactory
21-
{
22-
}
23-
2416
/// <summary>
2517
/// An interface for creating a component with no extra parameters (other than an <see cref="IHostEnvironment"/>).
2618
/// </summary>

src/Microsoft.ML.Core/Data/ServerChannel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public void Acknowledge(Action<Bundle> toDo)
141141
/// Entry point factory for creating <see cref="IServer"/> instances.
142142
/// </summary>
143143
[TlcModule.ComponentKind("Server")]
144-
public interface IServerFactory : IArgsComponent, IComponentFactory<IChannel, IServer>
144+
public interface IServerFactory : IComponentFactory<IChannel, IServer>
145145
{
146146
new IServer CreateComponent(IHostEnvironment env, IChannel ch);
147147
}

src/Microsoft.ML.Data/Commands/CrossValidationCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using Microsoft.ML.Runtime.Command;
1212
using Microsoft.ML.Runtime.CommandLine;
1313
using Microsoft.ML.Runtime.Data;
14-
using Microsoft.ML.Runtime.EntryPoints;
1514
using Microsoft.ML.Runtime.Internal.Calibration;
1615
using Microsoft.ML.Runtime.Internal.Utilities;
1716

src/Microsoft.ML.Data/Commands/DataCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using Microsoft.ML.Runtime.Command;
1010
using Microsoft.ML.Runtime.CommandLine;
1111
using Microsoft.ML.Runtime.Data.IO;
12-
using Microsoft.ML.Runtime.EntryPoints;
1312
using Microsoft.ML.Runtime.Internal.Utilities;
1413
using Microsoft.ML.Runtime.Model;
1514

src/Microsoft.ML.Data/Commands/EvaluateCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using Microsoft.ML.Runtime.Command;
1010
using Microsoft.ML.Runtime.CommandLine;
1111
using Microsoft.ML.Runtime.Data;
12-
using Microsoft.ML.Runtime.EntryPoints;
1312
using Microsoft.ML.Runtime.Internal.Utilities;
1413

1514
[assembly: LoadableClass(EvaluateTransform.Summary, typeof(IDataTransform), typeof(EvaluateTransform), typeof(EvaluateTransform.Arguments), typeof(SignatureDataTransform),

src/Microsoft.ML.Data/Commands/SaveDataCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using Microsoft.ML.Runtime.CommandLine;
1212
using Microsoft.ML.Runtime.Data;
1313
using Microsoft.ML.Runtime.Data.IO;
14-
using Microsoft.ML.Runtime.EntryPoints;
1514
using Microsoft.ML.Runtime.Internal.Utilities;
1615

1716
[assembly: LoadableClass(SaveDataCommand.Summary, typeof(SaveDataCommand), typeof(SaveDataCommand.Arguments), typeof(SignatureCommand),

src/Microsoft.ML.Data/Commands/ScoreCommand.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
using Microsoft.ML.Runtime.CommandLine;
1313
using Microsoft.ML.Runtime.Data;
1414
using Microsoft.ML.Runtime.Data.IO;
15-
using Microsoft.ML.Runtime.EntryPoints;
1615
using Microsoft.ML.Runtime.Internal.Utilities;
17-
using Microsoft.ML.Runtime.Model;
1816

1917
[assembly: LoadableClass(ScoreCommand.Summary, typeof(ScoreCommand), typeof(ScoreCommand.Arguments), typeof(SignatureCommand),
2018
"Score Predictor", "Score")]

src/Microsoft.ML.Data/Commands/TestCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using Microsoft.ML.Runtime.Command;
88
using Microsoft.ML.Runtime.CommandLine;
99
using Microsoft.ML.Runtime.Data;
10-
using Microsoft.ML.Runtime.EntryPoints;
1110
using Microsoft.ML.Runtime.Internal.Utilities;
1211

1312
[assembly: LoadableClass(TestCommand.Summary, typeof(TestCommand), typeof(TestCommand.Arguments), typeof(SignatureCommand),

src/Microsoft.ML.Data/Commands/TrainCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
using Microsoft.ML.Runtime.CommandLine;
1414
using Microsoft.ML.Runtime.Data;
1515
using Microsoft.ML.Runtime.Data.IO;
16-
using Microsoft.ML.Runtime.EntryPoints;
1716
using Microsoft.ML.Runtime.Internal.Calibration;
1817
using Microsoft.ML.Runtime.Internal.Utilities;
1918
using Microsoft.ML.Runtime.Model;

0 commit comments

Comments
 (0)