-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Documentation fixes for the issues in #664 #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 9b7eab3.
| This transform removes the entire row if any of the input columns have a missing value in that row. | ||
| This preprocessing is required for many ML algorithms that cannot work with missing values. | ||
| Useful if any missing entry invalidates the entire row. | ||
| If the <see cref="Microsoft.ML.Runtime.Data.NAFilter.Defaults.Complement"/> is set to true, this transform would do the exact opposite, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complement [](start = 70, length = 10)
XML comment has cref attribute 'Complement' that could not be resolved #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the right class name? Found this instead: microsoft.ml.runtime.data.nafilter.arguments.complement #Pending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are both the same thing, but using this one since the Microsoft.ML namespace is the the user facing one with the current api.
they will eventually get reconciled with the new api work.
In reply to: 208697780 [](ancestors = 208697780)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaults.Complement isn't showing in the API browser #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reply to: 208699506 [](ancestors = 208699506)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, sorry, Didn't see the update.
#Resolved
Ivanidzo4ka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
ganik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
fixes #664 |
Linked Microsoft.ML.SymSgdBinaryClassifier to its documentation.
Fixes the missing type in the list element of the FastTree documentation.
Indented examples.