Skip to content

Conversation

@sfilipi
Copy link
Member

@sfilipi sfilipi commented Aug 8, 2018

Linked Microsoft.ML.SymSgdBinaryClassifier to its documentation.
Fixes the missing type in the list element of the FastTree documentation.
Indented examples.

This transform removes the entire row if any of the input columns have a missing value in that row.
This preprocessing is required for many ML algorithms that cannot work with missing values.
Useful if any missing entry invalidates the entire row.
If the <see cref="Microsoft.ML.Runtime.Data.NAFilter.Defaults.Complement"/> is set to true, this transform would do the exact opposite,
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complement [](start = 70, length = 10)

XML comment has cref attribute 'Complement' that could not be resolved #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the P: notation in front of the namespace.
@sharwell, this makes the compiler happy 'sometimes'.


In reply to: 208667529 [](ancestors = 208667529)

Copy link

@JRAlexander JRAlexander Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the right class name? Found this instead: microsoft.ml.runtime.data.nafilter.arguments.complement #Pending

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are both the same thing, but using this one since the Microsoft.ML namespace is the the user facing one with the current api.
they will eventually get reconciled with the new api work.


In reply to: 208697780 [](ancestors = 208697780)

Copy link

@JRAlexander JRAlexander Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults.Complement isn't showing in the API browser #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@JRAlexander JRAlexander Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, sorry, Didn't see the update.
#Resolved

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ganik ganik self-requested a review August 8, 2018 19:08
Copy link
Member

@ganik ganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi
Copy link
Member Author

sfilipi commented Aug 8, 2018

fixes #664

@sfilipi sfilipi merged commit d0664c1 into dotnet:master Aug 8, 2018
@sfilipi sfilipi deleted the docFixes664 branch August 8, 2018 19:47
@shauheen shauheen mentioned this pull request Aug 9, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants