-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use APICompat from the SDK #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Yeah, fixing that. |
|
This should be working now. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6399 +/- ##
==========================================
+ Coverage 68.50% 68.52% +0.01%
==========================================
Files 1165 1167 +2
Lines 246211 246617 +406
Branches 25744 25764 +20
==========================================
+ Hits 168660 168985 +325
- Misses 70865 70919 +54
- Partials 6686 6713 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smasher164
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@ericstj Target framework .NETStandard,Version=v2.0 is no longer supported in the latest version. |
Also make sure we run API Compat even on non-stable packages. They just won't have baseline validation.
Yeah, that error was happening because we removed the empty assembly in c55727c#diff-fd2ae27a46a03c42f911d47f46937acbd3a2fa21214691de68fb89301652b1f2R6. I've suppressed it since that removal doesn't actually impact customers: they'll still be able to install the package and it will provide all the same functionality. |
We're using the 7.0 RC2 SDK which has support for multiple assembly packages.