Skip to content

Commit c55727c

Browse files
Fixed Nuget Pack warning. (#5994)
1 parent 791e37e commit c55727c

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

eng/pkg/Pack.props

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
<PropertyGroup>
44
<PackageAssetsPath>$(ArtifactsDir)pkgassets/</PackageAssetsPath>
55
<IncludeSymbols>true</IncludeSymbols>
6-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
76
<IsSymbolsPackage Condition="$(MSBuildProjectName.Contains('.snupkg'))">true</IsSymbolsPackage>
87
<PackageIdFolderName>$(MSBuildProjectName.Replace('.symbols', ''))</PackageIdFolderName>
98
<IncludeBuildOutput>true</IncludeBuildOutput>
109
<IsPackable>true</IsPackable>
11-
1210
</PropertyGroup>
1311

1412
<!-- nuspec properties -->
Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,36 @@
1-
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<Import Project="$(RepoRoot)eng/pkg/Pack.props" />
33
<PropertyGroup>
44
<Authors>Intel</Authors>
5-
<IncludeSymbols>true</IncludeSymbols>
6-
<IncludeBuildOutput>true</IncludeBuildOutput>
7-
<TargetFramework>netstandard2.0</TargetFramework>
5+
<TargetFrameworks>netstandard2.0</TargetFrameworks>
6+
<IncludeBuildOutput Condition="'$(TargetFramework)' == 'netstandard2.0'">false</IncludeBuildOutput>
87
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
98
<PackageDescription>$(MSBuildProjectName) contains the MKL library redistributed as a NuGet package.</PackageDescription>
109
<PackageTags>$(PackageTags) MLNET MKL</PackageTags>
10+
<!-- Empty package with no managed dependencies, only native, so no need to warn for empty lib folder/dependencies -->
11+
<NoWarn>$(NoWarn);NU5127;NU5128</NoWarn>
1112
<TargetsForTfmSpecificBuildOutput>$(TargetsForTfmSpecificBuildOutput);CopyProjectReferencesToPackage</TargetsForTfmSpecificBuildOutput>
1213
</PropertyGroup>
14+
1315
<PropertyGroup>
1416
<IncludeMLNetNotices>false</IncludeMLNetNotices>
17+
<!-- Intel MKL doesn't currently have symbols on non Windows systems. -->
18+
<IncludeSymbols Condition="'$(OS)' != 'Windows_NT'">false</IncludeSymbols>
1519
</PropertyGroup>
20+
1621
<ItemGroup>
1722
<Content Include="$(RepoRoot)eng\pkg\CommonPackage.props" Pack="true" PackagePath="build\netstandard2.0\$(MSBuildProjectName).props" />
1823
<Content Include="$(RepoRoot)eng\pkg\_._" Pack="true" PackagePath="lib\netstandard2.0\" />
1924
<Content Include="$(NuGetPackageRoot)mlnetmkldeps\$(MlNetMklDepsPackageVersion)\LICENSE.txt" Pack="true" PackagePath="" />
2025
</ItemGroup>
26+
2127
<Target DependsOnTargets="ResolveReferences" Name="CopyProjectReferencesToPackage">
2228
<ItemGroup>
2329
<!--Include native PDBs-->
24-
<BuildOutputInPackage Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklProxyNative.pdb')" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklProxyNative.pdb" TargetPath="..\..\runtimes\win-x86\native"/>
25-
<BuildOutputInPackage Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklProxyNative.pdb')" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklProxyNative.pdb" TargetPath="..\..\runtimes\win-x64\native"/>
26-
<BuildOutputInPackage Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklImports.pdb')" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklImports.pdb" TargetPath="..\..\runtimes\win-x86\native\MklImports.pdb"/>
27-
<BuildOutputInPackage Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklImports.pdb')" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklImports.pdb" TargetPath="..\..\runtimes\win-x64\native\MklImports.pdb"/>
30+
<TfmSpecificDebugSymbolsFile Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklProxyNative.pdb')" TargetFramework="netstandard2.0" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklProxyNative.pdb" TargetPath="/runtimes/win-x86/native"/>
31+
<TfmSpecificDebugSymbolsFile Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklProxyNative.pdb')" TargetFramework="netstandard2.0" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklProxyNative.pdb" TargetPath="/runtimes/win-x64/native"/>
32+
<TfmSpecificDebugSymbolsFile Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklImports.pdb')" TargetFramework="netstandard2.0" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x86\native\MklImports.pdb" TargetPath="/runtimes/win-x86/native/MklImports.pdb"/>
33+
<TfmSpecificDebugSymbolsFile Condition="Exists('$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklImports.pdb')" TargetFramework="netstandard2.0" Include="$(PackageAssetsPath)$(PackageIdFolderName)\runtimes\win-x64\native\MklImports.pdb" TargetPath="/runtimes/win-x64/native/MklImports.pdb"/>
2834
</ItemGroup>
2935
</Target>
3036
</Project>

src/Microsoft.ML/Microsoft.ML.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<Import Project="$(RepoRoot)eng/pkg/Pack.props"/>
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>

0 commit comments

Comments
 (0)