Skip to content

Fix CategoricalHashTransform to handle OutputKind "Key" #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2019
Merged

Fix CategoricalHashTransform to handle OutputKind "Key" #2017

merged 2 commits into from
Jan 7, 2019

Conversation

@Ivanidzo4ka
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka commented Jan 4, 2019

fixes #1939.
Duplicate of #1941, but since Gani is out, I want to finish it.

sfilipi
sfilipi approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Copy link
Contributor Author

Ivanidzo4ka commented Jan 4, 2019

@montebhoover @shmoradims I believe this bug prevents NimbusML to be updated for latest version, are you interested in this fix?

@Ivanidzo4ka
Copy link
Contributor Author

Ivanidzo4ka commented Jan 4, 2019 •
edited
Loading 

    public OneHotEncodingTransformer(ValueToKeyMappingEstimator term, IEstimator<ITransformer> toVector, IDataView input)

make it internal #Closed

Refers to: src/Microsoft.ML.Transforms/OneHotEncoding.cs:147 in 5a3c9ad. [](commit_id = 5a3c9ad, deletion_comment = False)

artidoro
artidoro approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit bb46fdf into dotnet:master Jan 7, 2019
@Ivanidzo4ka Ivanidzo4ka mentioned this pull request Jan 7, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TomFinley TomFinley Awaiting requested review from TomFinley

@montebhoover montebhoover Awaiting requested review from montebhoover

@abgoswam abgoswam Awaiting requested review from abgoswam

@shmoradims shmoradims Awaiting requested review from shmoradims

2 more reviewers

@artidoro artidoro artidoro approved these changes

@sfilipi sfilipi sfilipi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CategoricalHashTransform breaks on OutputKind "Key"

3 participants

@Ivanidzo4ka @artidoro @sfilipi