Skip to content

Conversation

@ganik
Copy link
Member

@ganik ganik commented Dec 20, 2018

fixes #1939

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ganik! That was a pretty nasty bug.

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Dec 20, 2018

Can we have test?
I'm actually curios how I miss that case during testing....
Oh, I remember now.
From API point of view, that Key Output kind doesn't make much sense, you just apply hash transform, and you do nothing else, after that.
So this is why I remove that option from static extensions, but it remain in arguments class and entrypoints.

Still, can you add few more lines in already existing test to run this case as well?

@ganik
Copy link
Member Author

ganik commented Dec 26, 2018

Very good suggestion, once I added test I see that GetOutputSchema() needs to be changed as well otherwise it throws. Same issue exists for OneHotEncoding. I spent couple hours but couldnt figure out how to fix GetOutoutSchema. @ivmatan Could you pls take over this PR since I am OOF till end of Jan. Would be great if it makes into ML.NET 0.9 release


In reply to: 449154511 [](ancestors = 449154511)

@Ivanidzo4ka
Copy link
Contributor

closed in #2017

@Ivanidzo4ka Ivanidzo4ka closed this Jan 7, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CategoricalHashTransform breaks on OutputKind "Key"

3 participants