[Java.Interop] use $(DebugType) portable #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#6799 dotnet/android#6799 is missing `Java.Interop.pdb` when building in `Release` mode. I suspect this is due to `$(DebugType)` set to `full`. This creates `Java.Interop.dll.mdb`! The modern approach is to use `portable` for both `Debug` and `Release` builds, so we should just use that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#6799
dotnet/android#6799 is missing
Java.Interop.pdbwhenbuilding in
Releasemode. I suspect this is due to$(DebugType)set to
full. This createsJava.Interop.dll.mdb!The modern approach is to use
portablefor bothDebugandReleasebuilds, so we should just use that.