[installer] add missing .pdb files to Xamarin.Android #6799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
As I suspected this hit: |
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Feb 28, 2022
Context: dotnet/android#6799 dotnet/android#6799 is missing `Java.Interop.pdb` when building in `Release` mode. I suspect this is due to `$(DebugType)` set to `full`. This creates `Java.Interop.dll.mdb`! The modern approach is to use `portable` for both `Debug` and `Release` builds, so we should just use that.
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Mar 1, 2022
Context: dotnet/android#6799 dotnet/android#6799 is missing `Java.Interop.pdb` when building in `Release` configuration. I suspect this is due to `$(DebugType)`=full, which creates `Java.Interop.dll.mdb`! The modern approach is to use `portable` for both `Debug` and `Release` configurations, so we should just use that.
Partially fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1467817 A warning is printed when building with `-p:MonoSymbolArchive=true`: Warning: Directory obj\Release\120\android\assets contains Java.Interop.dll but no debug symbols file was found. It turns out we are missing `Java.Interop.pdb` from our installer? I went ahead and also added `Mono.Posix.pdb` and `System.EnterpriseServices.pdb`, since we appear to have these in build output.
Changes: dotnet/java-interop@cbd9666...aae23c9 * [ci] Move CI builds to 1ES's hardened images. * [Java.Interop] use $(DebugType)=portable
jonathanpeppers
force-pushed
the
classic-missing-pdbs
branch
from
e69214a to
4d0d31c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1467817
A warning is printed when building with
-p:MonoSymbolArchive=true:It turns out we are missing
Java.Interop.pdbfrom our installer?I went ahead and also added
Mono.Posix.pdbandSystem.EnterpriseServices.pdb, since we appear to have these inbuild output.