[Java.Interop{,Export}] Set Version to 0.1.0.0 #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3e6a623 Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330 An unfortunate unexpected breakage occurred due to commit 3e6a623: the version of `Java.Interop.dll` changed -- which we *should* have expected but completely overlooked & forgot -- which in turn meant that *everything* which depends upon it -- which is everything -- started breaking due to the version change, e.g. error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Java.Interop, Version=0.1.6.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Java.Interop' with identity 'Java.Interop, Version=0.1.2.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' As the primary motivation with 3e6a623 was to improve the use of *MSBuild* task assemblies -- which `Java.Interop.dll` is *not* -- modify the logic of 3e6a623 so that: 1. `build-tools/scripts/Version.props` allows the `$(Version)` property to be *overridden*, and 2. Override `$(Version)` within `src/Java.Interop`, `src/Java.Interop.Dynamic`, and `src/Java.Interop.Export`. `Java.Interop.Dynamic.dll` and `Java.Interop.Export.dll` aren't shipped (yet), but we would like them to eventually, and it's "nicer" if they all share the same assembly version.
jpobst
approved these changes
Oct 18, 2021
jonpryor
force-pushed
the
jonp-reset-JI-version
branch
from
a4b7c71 to
d8b669d
Compare
jonpryor
added a commit
that referenced
this pull request
Oct 18, 2021
Commit 3e6a623 Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330 An unfortunate unexpected breakage occurred due to commit 3e6a623: the version of `Java.Interop.dll` changed -- which we *should* have expected but completely overlooked & forgot -- which in turn meant that *everything* which depends upon it -- which is everything -- started breaking due to the version change, e.g. error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Java.Interop, Version=0.1.6.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Java.Interop' with identity 'Java.Interop, Version=0.1.2.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' As the primary motivation with 3e6a623 was to improve the use of *MSBuild* task assemblies -- which `Java.Interop.dll` is *not* -- modify the logic of 3e6a623 so that: 1. `build-tools/scripts/Version.props` allows the `$(Version)` property to be *overridden*, and 2. Override `$(Version)` within `src/Java.Interop`, `src/Java.Interop.Dynamic`, and `src/Java.Interop.Export`. `Java.Interop.Dynamic.dll` and `Java.Interop.Export.dll` aren't shipped (yet), but we would like them to eventually, and it's "nicer" if they all share the same assembly version.
jonpryor
added a commit
that referenced
this pull request
Oct 18, 2021
Commit 3e6a623 Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330 An unfortunate unexpected breakage occurred due to commit 3e6a623: the version of `Java.Interop.dll` changed -- which we *should* have expected but completely overlooked & forgot -- which in turn meant that *everything* which depends upon it -- which is everything -- started breaking due to the version change, e.g. error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Java.Interop, Version=0.1.6.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Java.Interop' with identity 'Java.Interop, Version=0.1.2.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' As the primary motivation with 3e6a623 was to improve the use of *MSBuild* task assemblies -- which `Java.Interop.dll` is *not* -- modify the logic of 3e6a623 so that: 1. `build-tools/scripts/Version.props` allows the `$(Version)` property to be *overridden*, and 2. Override `$(Version)` within `src/Java.Interop`, `src/Java.Interop.Dynamic`, and `src/Java.Interop.Export`. `Java.Interop.Dynamic.dll` and `Java.Interop.Export.dll` aren't shipped (yet), but we would like them to eventually, and it's "nicer" if they all share the same assembly version.
jonpryor
added a commit
that referenced
this pull request
Oct 18, 2021
Commit 3e6a623 Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330 An unfortunate unexpected breakage occurred due to commit 3e6a623: the version of `Java.Interop.dll` changed -- which we *should* have expected but completely overlooked & forgot -- which in turn meant that *everything* which depends upon it -- which is everything -- started breaking due to the version change, e.g. error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Java.Interop, Version=0.1.6.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Java.Interop' with identity 'Java.Interop, Version=0.1.2.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' As the primary motivation with 3e6a623 was to improve the use of *MSBuild* task assemblies -- which `Java.Interop.dll` is *not* -- modify the logic of 3e6a623 so that: 1. `build-tools/scripts/Version.props` allows the `$(Version)` property to be *overridden*, and 2. Override `$(Version)` within `src/Java.Interop`, `src/Java.Interop.Dynamic`, and `src/Java.Interop.Export`. `Java.Interop.Dynamic.dll` and `Java.Interop.Export.dll` aren't shipped (yet), but we would like them to eventually, and it's "nicer" if they all share the same assembly version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3e6a623
Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330
An unfortunate unexpected breakage occurred due to commit 3e6a623:
the version of
Java.Interop.dllchanged -- which we should haveexpected but completely overlooked & forgot -- which in turn meant
that everything which depends upon it -- which is everything --
started breaking due to the version change, e.g.
As the primary motivation with 3e6a623 was to improve the use of
MSBuild task assemblies -- which
Java.Interop.dllis not --modify the logic of 3e6a623 so that:
build-tools/scripts/Version.propsallows the$(Version)property to be overridden, and
Override
$(Version)withinsrc/Java.Interop,src/Java.Interop.Dynamic, andsrc/Java.Interop.Export.Java.Interop.Dynamic.dllandJava.Interop.Export.dllaren'tshipped (yet), but we would like them to eventually, and it's "nicer"
if they all share the same assembly version.