Skip to content

Commit b288839

Browse files
authored
[Java.Interop{,.Dynamic,.Export}] Set Version to 0.1.0.0 (#894)
Commit 3e6a623 Context: https://discord.com/channels/732297728826277939/732297837953679412/898675755779768330 An unfortunate unexpected breakage occurred due to commit 3e6a623: the version of `Java.Interop.dll` changed -- which we *should* have expected but completely overlooked & forgot -- which in turn meant that *everything* which depends upon it -- which is everything -- started breaking due to the version change, e.g. error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Java.Interop, Version=0.1.6.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Java.Interop' with identity 'Java.Interop, Version=0.1.2.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' As the primary motivation with 3e6a623 was to improve the use of *MSBuild* task assemblies -- which `Java.Interop.dll` is *not* -- modify the logic of 3e6a623 so that: 1. `build-tools/scripts/Version.props` allows the `$(Version)` property to be *overridden*, and 2. Override `$(Version)` within `src/Java.Interop`, `src/Java.Interop.Dynamic`, and `src/Java.Interop.Export`. `Java.Interop.Dynamic.dll` and `Java.Interop.Export.dll` aren't shipped (yet), but we would like them to eventually, and it's "nicer" if they all share the same assembly version.
1 parent 8ccb837 commit b288839

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

build-tools/scripts/Version.props.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<Version>@VERSION@</Version>
3+
<Version Condition=" '$(Version)' == '' ">@VERSION@</Version>
44
<InformationalVersion>@VERSION@ git-rev-head:@COMMIT@ git-branch:@BRANCH@</InformationalVersion>
55
<Company>Microsoft Corporation</Company>
66
<Copyright>Microsoft Corporation</Copyright>

src/Java.Interop.Dynamic/Java.Interop.Dynamic.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<SignAssembly>true</SignAssembly>
88
<AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile>
99
<AssemblyTitle>Java.Interop.Dynamic</AssemblyTitle>
10+
<Version>0.1.0.0</Version>
1011
</PropertyGroup>
1112
<PropertyGroup>
1213
<OutputPath>$(ToolOutputFullPath)</OutputPath>

src/Java.Interop.Export/Java.Interop.Export.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<SignAssembly>true</SignAssembly>
88
<AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile>
99
<AssemblyTitle>Java.Interop.Export</AssemblyTitle>
10+
<Version>0.1.0.0</Version>
1011
</PropertyGroup>
1112
<PropertyGroup>
1213
<OutputPath>$(ToolOutputFullPath)</OutputPath>

src/Java.Interop/Java.Interop-MonoAndroid.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<LangVersion>8.0</LangVersion>
1818
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
1919
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
20+
<Version>0.1.0.0</Version>
2021
</PropertyGroup>
2122
<Import Project="..\..\Directory.Build.props" />
2223
<PropertyGroup>

src/Java.Interop/Java.Interop.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<Nullable>enable</Nullable>
3131
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
3232
<MSBuildWarningsAsMessages>NU1702</MSBuildWarningsAsMessages>
33+
<Version>0.1.0.0</Version>
3334
</PropertyGroup>
3435
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
3536
<DefineConstants>DEBUG;$(DefineConstants)</DefineConstants>

0 commit comments

Comments
 (0)