Skip to content

[jcw-gen] Make MSBuild warning/error strings localizable. #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2020
Merged

[jcw-gen] Make MSBuild warning/error strings localizable. #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b96f463
[jcw-gen] Make MSBuild warning/error strings localizable.
jpobst Aug 24, 2020
6ade7ed
Address feedback.
jpobst Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions src/Java.Interop.Localization/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 45 additions & 0 deletions src/Java.Interop.Localization/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="CecilResolver_XA0009" xml:space="preserve">
<value>Error while loading assembly: '{0}'.</value>
<comment>{0} - File name</comment>
</data>
<data name="Generator_BG4000" xml:space="preserve">
<value>Failed to remove old constants: {0}.</value>
<comment>{0} - The list of constants that could not be removed.
Expand Down Expand Up @@ -287,4 +291,45 @@ The following terms should not be translated: Metadata.xml.</comment>
<value>For type '{0}', base interface '{1}' is invalid.</value>
<comment>{0}, {1} - .NET types.</comment>
</data>
<data name="JavaCallableWrappers_XA4200" xml:space="preserve">
<value>Cannot generate Java wrapper for type '{0}'. Only 'class' types are supported.</value>
<comment>{0} - Java type.
The following terms should not be translated:
class.</comment>
</data>
<data name="JavaCallableWrappers_XA4201" xml:space="preserve">
<value>Cannot determine JNI name for type '{0}'.</value>
<comment>{0} - Java type.
The following terms should not be translated: JNI.</comment>
</data>
<data name="JavaCallableWrappers_XA4203" xml:space="preserve">
<value>The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</value>
Copy link
Contributor

@brendanzagaeski brendanzagaeski Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's fine to leave it as it is, but just to be excessively thorough, note that the English words example and My in com.example.MyClass will lose a tiny bit of special meaning in the translated versions of the message.

Although the Microsoft internal FAQ on fictitious names doesn't specifically mention example.com, I suspect that's because it's an even broader case that is accepted industry-wide (https://tools.ietf.org/html/rfc2606) and so doesn't require a specific mention in the FAQ.

<comment>{0} - Java type.
The following terms should not be translated:
Name, com.example.MyClass.</comment>
</data>
<data name="JavaCallableWrappers_XA4204" xml:space="preserve">
<value>Unable to resolve interface type '{0}'. Are you missing an assembly reference?</value>
<comment>{0} - Java interface.</comment>
</data>
<data name="JavaCallableWrappers_XA4205" xml:space="preserve">
<value>[ExportField] can only be used on methods with 0 parameters.</value>
<comment>The following terms should not be translated: [ExportField].</comment>
</data>
<data name="JavaCallableWrappers_XA4206" xml:space="preserve">
<value>[Export] cannot be used on a generic type.</value>
<comment>The following terms should not be translated: [Export].</comment>
</data>
<data name="JavaCallableWrappers_XA4207" xml:space="preserve">
<value>[ExportField] cannot be used on a generic type.</value>
<comment>The following terms should not be translated: [ExportField].</comment>
</data>
<data name="JavaCallableWrappers_XA4208" xml:space="preserve">
<value>[ExportField] cannot be used on a method returning 'void'.</value>
<comment>The following terms should not be translated: [ExportField], void.</comment>
</data>
<data name="JavaCallableWrappers_XA4217" xml:space="preserve">
<value>Cannot override Kotlin-generated method '{0}' because it is not a valid Java method name. This method can only be overridden from Kotlin.</value>
<comment>{0} - Kotlin method name.</comment>
</data>
</root>
55 changes: 55 additions & 0 deletions src/Java.Interop.Localization/xlf/Resources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="cs" original="../Resources.resx">
<body>
<trans-unit id="CecilResolver_XA0009">
<source>Error while loading assembly: '{0}'.</source>
<target state="new">Error while loading assembly: '{0}'.</target>
<note>{0} - File name</note>
</trans-unit>
<trans-unit id="Generator_BG4000">
<source>Failed to remove old constants: {0}.</source>
<target state="new">Failed to remove old constants: {0}.</target>
Expand Down Expand Up @@ -208,6 +213,56 @@ The following terms should not be translated: Metadata.xml.</note>
<target state="new">For type '{0}', base interface '{1}' is invalid.</target>
<note>{0}, {1} - .NET types.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4200">
<source>Cannot generate Java wrapper for type '{0}'. Only 'class' types are supported.</source>
<target state="new">Cannot generate Java wrapper for type '{0}'. Only 'class' types are supported.</target>
<note>{0} - Java type.
The following terms should not be translated:
class.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4201">
<source>Cannot determine JNI name for type '{0}'.</source>
<target state="new">Cannot determine JNI name for type '{0}'.</target>
<note>{0} - Java type.
The following terms should not be translated: JNI.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4203">
<source>The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</source>
<target state="new">The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</target>
<note>{0} - Java type.
The following terms should not be translated:
Name, com.example.MyClass.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4204">
<source>Unable to resolve interface type '{0}'. Are you missing an assembly reference?</source>
<target state="new">Unable to resolve interface type '{0}'. Are you missing an assembly reference?</target>
<note>{0} - Java interface.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4205">
<source>[ExportField] can only be used on methods with 0 parameters.</source>
<target state="new">[ExportField] can only be used on methods with 0 parameters.</target>
<note>The following terms should not be translated: [ExportField].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4206">
<source>[Export] cannot be used on a generic type.</source>
<target state="new">[Export] cannot be used on a generic type.</target>
<note>The following terms should not be translated: [Export].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4207">
<source>[ExportField] cannot be used on a generic type.</source>
<target state="new">[ExportField] cannot be used on a generic type.</target>
<note>The following terms should not be translated: [ExportField].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4208">
<source>[ExportField] cannot be used on a method returning 'void'.</source>
<target state="new">[ExportField] cannot be used on a method returning 'void'.</target>
<note>The following terms should not be translated: [ExportField], void.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4217">
<source>Cannot override Kotlin-generated method '{0}' because it is not a valid Java method name. This method can only be overridden from Kotlin.</source>
<target state="new">Cannot override Kotlin-generated method '{0}' because it is not a valid Java method name. This method can only be overridden from Kotlin.</target>
<note>{0} - Kotlin method name.</note>
</trans-unit>
</body>
</file>
</xliff>
55 changes: 55 additions & 0 deletions src/Java.Interop.Localization/xlf/Resources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
<file datatype="xml" source-language="en" target-language="de" original="../Resources.resx">
<body>
<trans-unit id="CecilResolver_XA0009">
<source>Error while loading assembly: '{0}'.</source>
<target state="new">Error while loading assembly: '{0}'.</target>
<note>{0} - File name</note>
</trans-unit>
<trans-unit id="Generator_BG4000">
<source>Failed to remove old constants: {0}.</source>
<target state="new">Failed to remove old constants: {0}.</target>
Expand Down Expand Up @@ -208,6 +213,56 @@ The following terms should not be translated: Metadata.xml.</note>
<target state="new">For type '{0}', base interface '{1}' is invalid.</target>
<note>{0}, {1} - .NET types.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4200">
<source>Cannot generate Java wrapper for type '{0}'. Only 'class' types are supported.</source>
<target state="new">Cannot generate Java wrapper for type '{0}'. Only 'class' types are supported.</target>
<note>{0} - Java type.
The following terms should not be translated:
class.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4201">
<source>Cannot determine JNI name for type '{0}'.</source>
<target state="new">Cannot determine JNI name for type '{0}'.</target>
<note>{0} - Java type.
The following terms should not be translated: JNI.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4203">
<source>The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</source>
<target state="new">The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</target>
<note>{0} - Java type.
The following terms should not be translated:
Name, com.example.MyClass.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4204">
<source>Unable to resolve interface type '{0}'. Are you missing an assembly reference?</source>
<target state="new">Unable to resolve interface type '{0}'. Are you missing an assembly reference?</target>
<note>{0} - Java interface.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4205">
<source>[ExportField] can only be used on methods with 0 parameters.</source>
<target state="new">[ExportField] can only be used on methods with 0 parameters.</target>
<note>The following terms should not be translated: [ExportField].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4206">
<source>[Export] cannot be used on a generic type.</source>
<target state="new">[Export] cannot be used on a generic type.</target>
<note>The following terms should not be translated: [Export].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4207">
<source>[ExportField] cannot be used on a generic type.</source>
<target state="new">[ExportField] cannot be used on a generic type.</target>
<note>The following terms should not be translated: [ExportField].</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4208">
<source>[ExportField] cannot be used on a method returning 'void'.</source>
<target state="new">[ExportField] cannot be used on a method returning 'void'.</target>
<note>The following terms should not be translated: [ExportField], void.</note>
</trans-unit>
<trans-unit id="JavaCallableWrappers_XA4217">
<source>Cannot override Kotlin-generated method '{0}' because it is not a valid Java method name. This method can only be overridden from Kotlin.</source>
<target state="new">Cannot override Kotlin-generated method '{0}' because it is not a valid Java method name. This method can only be overridden from Kotlin.</target>
<note>{0} - Kotlin method name.</note>
</trans-unit>
</body>
</file>
</xliff>
Loading