[jcw-gen] Make MSBuild warning/error strings localizable. #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brendanzagaeski
left a comment
brendanzagaeski
left a comment
There was a problem hiding this comment.
Looks good! I'll comment with just a few tiny wording ideas.
brendanzagaeski
approved these changes
Aug 26, 2020
| </data> | ||
| <data name="JavaCallableWrappers_XA4203" xml:space="preserve"> | ||
| <value>The 'Name' property must be a fully qualified 'package.TypeName' value, and no package was found for '{0}'.</value> | ||
| <value>The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</value> |
Contributor
There was a problem hiding this comment.
I believe it's fine to leave it as it is, but just to be excessively thorough, note that the English words example and My in com.example.MyClass will lose a tiny bit of special meaning in the translated versions of the message.
Although the Microsoft internal FAQ on fictitious names doesn't specifically mention example.com, I suspect that's because it's an even broader case that is accepted industry-wide (https://tools.ietf.org/html/rfc2606) and so doesn't require a specific mention in the FAQ.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates MSBuild warnings and errors in
Java.Interop.Tools.JavaCallableWrappersandJava.Interop.Tools.Cecilto be localizable, building on work done in #689.