[Xamarin.Android.Tools.ApiXmlAdjuster] Attributes are optional #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0881acc [broke][0] the [build][1] via unit test failure: System.Exception : /var/folders/l8/73t5whsx7dj5v5gh_bn7zxlr0000gn/T/tmp28cf44e7.tmp (5,5): Element 'constructor' requires attribute 'jni-signature' at Xamarin.Android.Tools.ApiXmlAdjuster.XmlUtil.GetRequiredAttribute (System.Xml.XmlReader reader, System.String name) at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.LoadMemberAttributes (Xamarin.Android.Tools.ApiXmlAdjuster.JavaMember member, System.Xml.XmlReader reader) ... This was generated from e.g. `make run-test-generator-core` and processing a "legacy" file in the form of `tools/generator/Tests-Core/api-cp.xml` (whereby "legacy" means "didn't contain the newly required `//constructor/@jni-signature` XML attribute). There are two plausible fixes: 1. Update `api-cp.xml` so that it provides the attribute that 0881acc requires, or 2. Make the attributes *not* required attributes. Since I don't know what the larger ecosystem may be doing with these API XML files, I chose the conservative approach (2). [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/Java.Interop/261/testReport/junit/generatortests/AdjusterTests/Process/ [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/Java.Interop/261/
grendello
approved these changes
Jun 26, 2018
jonpryor
added a commit
that referenced
this pull request
Aug 2, 2018
Commit 0881acc [broke][0] the [build][1] via unit test failure: System.Exception : /var/folders/l8/73t5whsx7dj5v5gh_bn7zxlr0000gn/T/tmp28cf44e7.tmp (5,5): Element 'constructor' requires attribute 'jni-signature' at Xamarin.Android.Tools.ApiXmlAdjuster.XmlUtil.GetRequiredAttribute (System.Xml.XmlReader reader, System.String name) at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.LoadMemberAttributes (Xamarin.Android.Tools.ApiXmlAdjuster.JavaMember member, System.Xml.XmlReader reader) ... This was generated from e.g. `make run-test-generator-core` and processing a "legacy" file in the form of `tools/generator/Tests-Core/api-cp.xml` (whereby "legacy" means "didn't contain the newly required `//constructor/@jni-signature` XML attribute). There are two plausible fixes: 1. Update `api-cp.xml` so that it provides the attribute that 0881acc requires, or 2. Make the attributes *not* required attributes. Since I don't know what the larger ecosystem may be doing with these API XML files, I chose the conservative approach (2). [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/Java.Interop/261/testReport/junit/generatortests/AdjusterTests/Process/ [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/Java.Interop/261/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0881acc broke the build via unit test failure:
This was generated from e.g.
make run-test-generator-coreandprocessing a "legacy" file in the form of
tools/generator/Tests-Core/api-cp.xml(whereby "legacy" means"didn't contain the newly required
//constructor/@jni-signatureXML attribute).
There are two plausible fixes:
api-cp.xmlso that it provides the attribute that0881acc requires, or
Since I don't know what the larger ecosystem may be doing with
these API XML files, I chose the conservative approach (2).