[java-interop] Do not redefine MONO_API* #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not redefine MONO_API* for mono's header files. This fixes the
warnings like this one:
```
In file included from java-interop-mono.c:2:
In file included from ./java-interop-mono.h:30:
In file included from /Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/metadata/assembly.h:8:
In file included from /Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/utils/mono-error.h:8:
/Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/utils/mono-publib.h(52,9): warning GE1D896A7: 'MONO_API_EXPORT' macro redefined [-Wmacro-redefined] [/Users/rodo/git/java.interop/src/java-interop/java-interop.csproj]
#define MONO_API_EXPORT __attribute__ ((__visibility__ ("default")))
^
./java-interop.h:14:11: note: previous definition is here
#define MONO_API_EXPORT __attribute__ ((visibility ("default")))
^
1 warning generated.
```
Contributor
|
Side note: reported unit test failure was introduced by 0881acc; PR #340 attempts to fix it. |
jonpryor
pushed a commit
that referenced
this pull request
Aug 2, 2018
Do not redefine MONO_API* for mono's header files. This fixes
warnings like this one:
In file included from java-interop-mono.c:2:
In file included from ./java-interop-mono.h:30:
In file included from /Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/metadata/assembly.h:8:
In file included from /Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/utils/mono-error.h:8:
/Library/Frameworks/Mono.framework/Headers/mono-2.0/mono/utils/mono-publib.h(52,9): warning GE1D896A7: 'MONO_API_EXPORT' macro redefined [-Wmacro-redefined] [/Users/rodo/git/java.interop/src/java-interop/java-interop.csproj]
#define MONO_API_EXPORT __attribute__ ((__visibility__ ("default")))
^
./java-interop.h:14:11: note: previous definition is here
#define MONO_API_EXPORT __attribute__ ((visibility ("default")))
^
1 warning generated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not redefine MONO_API
#define's for mono's header files. This fixes thewarnings like this one: