[build] introduce xamarin-android-tools.override.props
#1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#8360 When .NET 8 RC 2 took a dependency on dotnet/runtime 7.0.12 and 6.0.23, we added a `xamarin-android-tools.override.props` with the contents: <Project> <PropertyGroup> <RestoreAdditionalProjectSources> https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-26e0f822/nuget/v3/index.json; https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-301ba1ee/nuget/v3/index.json; </RestoreAdditionalProjectSources> </PropertyGroup> </Project> Unfortunately, this still broke for the submodule: external/java.interop/external/xamarin-android-tools This led to the error during the `prepare java.interop Debug` stage: tests/api-compatibility/api-compatibility.targets(3,3): warning MSB4011: "Configuration.props" cannot be imported again. It was already imported at "build-tools/scripts/RunTests.targets (7,3)". This is most likely a build authoring error. This subsequent import will be ignored. external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.23) external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: - Found 86 version(s) in dotnet-public [ Nearest version: 7.0.0-preview.1.22076.8 ] external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ] external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.23) external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: - Found 86 version(s) in dotnet-public [ Nearest version: 7.0.0-preview.1.22076.8 ] external/Java.Interop/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj : error NU1102: - Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ] build-tools/scripts/DotNet.targets(19,5): error MSB3073: The command ""bin/Release/dotnet/dotnet" build -t:Prepare Java.Interop.sln -c Debug -p:JdksRoot= -p:DotnetToolPath=bin/Release/dotnet/dotnet -bl:build-tools/scripts/../../bin/BuildDebug/msbuild-20230925T183954-prepare-java-interop.binlog" exited with code 1. 1 Warning(s) 7 Error(s) Introduce a `xamarin-android-tools.override.props` to import `..\Directory.Build.props` and avoid this in the future.
Member
Author
|
I'll be testing this here: dotnet/android#8380 Checking CI to be sure it still breaks in the same way, then see if this fixes it. I was having trouble reproducing this issue on my Windows PC. |
Member
Author
|
Looks like the failing lane passed:
|
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Oct 2, 2023
Changes: dotnet/java-interop@75d8221...d7f41c4 * dotnet/java-interop@d7f41c4e: [build] introduce `xamarin-android-tools.override.props` (dotnet/java-interop#1148) * dotnet/java-interop@9ac0dd4c: Bump to xamarin/xamarin-android-tools/main@8a971d9 (dotnet/java-interop#1146) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonathanpeppers
pushed a commit
to dotnet/android
that referenced
this pull request
Oct 10, 2023
Changes: dotnet/java-interop@75d8221...d7f41c4 * dotnet/java-interop@d7f41c4e: [build] introduce `xamarin-android-tools.override.props` (dotnet/java-interop#1148) * dotnet/java-interop@9ac0dd4c: Bump to xamarin/xamarin-android-tools/main@8a971d9 (dotnet/java-interop#1146) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonathanpeppers
pushed a commit
to dotnet/android
that referenced
this pull request
Oct 17, 2023
Changes: dotnet/java-interop@75d8221...d7f41c4 * dotnet/java-interop@d7f41c4e: [build] introduce `xamarin-android-tools.override.props` (dotnet/java-interop#1148) * dotnet/java-interop@9ac0dd4c: Bump to xamarin/xamarin-android-tools/main@8a971d9 (dotnet/java-interop#1146) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#8360
When .NET 8 RC 2 took a dependency on dotnet/runtime 7.0.12 and 6.0.23, we added a
xamarin-android-tools.override.propswith the contents:Unfortunately, this still broke for the submodule:
This led to the error during the
prepare java.interop Debugstage:Introduce a
xamarin-android-tools.override.propsto import..\Directory.Build.propsand avoid this in the future.