Skip to content

[build] don't pass $(RestoreAdditionalProjectSources) as a global property #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[build] don't pass $(RestoreAdditionalProjectSources) as a global property #8380

wants to merge 2 commits into from

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Sep 27, 2023

This partially reverts 4c7b645.

Opening this to test how we can fix this with a change in java.interop.

Ran:

git checkout 4c7b6455b7bbf60268520e8d55996133210d1a37~1 build-tools\scripts\DotNet.targets

@jonathanpeppers
[build] don't pass $(RestoreAdditionalProjectSources) as a global p…
8a06bdd 
…roperty

This partially reverts 4c7b645.

Opening this to test how we can fix this with a change in java.interop.

Ran:

    git checkout 4c7b645~1 build-tools\scripts\DotNet.targets
@jonathanpeppers jonathanpeppers added the do-not-merge PR should not be merged. label Sep 27, 2023
@jonathanpeppers jonathanpeppers mentioned this pull request Sep 27, 2023
Merged
@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Sep 27, 2023

Ok still broken:

Now will check if dotnet/java-interop#1148 fixes it.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge PR should not be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonathanpeppers