Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Oct 8, 2025

Currently, if the build is supposed to produce RPM packages, but the tooling (i.e. fpm) is missing, a message will be logged and the build will skip the RPM package generation. This can result in successful builds that are missing the required artifacts.

Additional changes were needed, as RPM targets were being executed for any build that was running on RPM-based distro due to:

Condition=" '$(IsRPMBasedDistro)' == 'True' "

The use of property IsRPMBasedDistro was overloaded to mean both that the distro is RPM-based and that we want to build installers.

Property was set here:

<IsRPMBasedDistro Condition=" $(HostRid.StartsWith('rhel')) AND '$(HostRid)' != 'rhel.6-x64' ">true</IsRPMBasedDistro>
<IsRPMBasedDistro Condition=" $(HostRid.StartsWith('centos')) ">true</IsRPMBasedDistro>

For installer build we were passing this same property, which was already being set on rpm-based distros, so this wasn't correct:

additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:IsRPMBasedDistro=true'

I am now setting a different property, BuildSdkRpm, in scenarios where RPM packaging is desired. This matches DEB build experience, where we have a similar pair of properties: BuildSdkDeb and IsDebianBaseDistro.

Notes

Fix for 8.0.1xx - will be backported to other 8.0.x branches in support. Separate fix will be made for 9.0.

Contributes to #20561

@NikolaMilosavljevic
Copy link
Member Author

Failure in source-build and regular (non-pkg) Linux leg - neither of these should even attempt to build RPM packages, but that's what's happening. More changes are needed.

@NikolaMilosavljevic
Copy link
Member Author

Pushed a fix.

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Oct 13, 2025

This is now passing all checks - @marcpopMSFT is there a reason not to merge this yet? Same for 9.0 change: dotnet/sdk#51170

@marcpopMSFT
Copy link
Member

Branch is still open so we can merge.

@marcpopMSFT marcpopMSFT merged commit f0a87b2 into dotnet:release/8.0.1xx Oct 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants