Fail the RPM build if FPM tool is not present (#20633)

Author: marcpopMSFT

.vsts-ci.yml

@@ -288,7 +288,7 @@ extends:
             buildArchitecture: x64
             # Do not publish zips and tarballs. The linux-x64 binaries are
             # already published by Build_LinuxPortable_Release_x64
-            additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:IsRPMBasedDistro=true'
+            additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:BuildSdkRpm=true'
             linuxPortable: true
             runTests: false
         - template: eng/build.yml@self
@@ -301,7 +301,7 @@ extends:
             runtimeIdentifier: 'linux-arm64'
             # Do not publish zips and tarballs. The linux-x64 binaries are
             # already published by Build_LinuxPortable_Release_x64
-            additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:CLIBUILD_SKIP_TESTS=true  /p:IsRPMBasedDistro=true'
+            additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:CLIBUILD_SKIP_TESTS=true  /p:BuildSdkRpm=true'
             linuxPortable: true
             runTests: false
         - template: eng/build.yml@self

.vsts-pr.yml

@@ -247,7 +247,7 @@ stages:
         buildArchitecture: x64
         # Do not publish zips and tarballs. The linux-x64 binaries are
         # already published by Build_LinuxPortable_Release_x64
-        additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:IsRPMBasedDistro=true'
+        additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:BuildSdkRpm=true'
         linuxPortable: true
         runTests: false
     - template: eng/build-pr.yml
@@ -260,7 +260,7 @@ stages:
         runtimeIdentifier: 'linux-arm64'
         # Do not publish zips and tarballs. The linux-x64 binaries are
         # already published by Build_LinuxPortable_Release_x64
-        additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:CLIBUILD_SKIP_TESTS=true  /p:IsRPMBasedDistro=true'
+        additionalBuildParameters: '/p:PublishBinariesAndBadge=false /p:CLIBUILD_SKIP_TESTS=true  /p:BuildSdkRpm=true'
         linuxPortable: true
         runTests: false
     - template: eng/build-pr.yml

src/redist/targets/GenerateRPMs.targets

@@ -16,12 +16,12 @@
        build environment. https://github.com/dotnet/sdk/issues/41910 -->
   <Target Name="GenerateRpmsInner"
           DependsOnTargets="TestFPMTool;BuildRpms"
-          Condition=" '$(IsRPMBasedDistro)' == 'True' "
+          Condition=" '$(BuildSdkRpm)' == 'True' "
           Outputs="@(GeneratedInstallers)"/>
 
   <Target Name="BuildRpms"
           DependsOnTargets="GenerateSdkRpm"
-          Condition=" '$(IsRPMBasedDistro)' == 'True' and '$(FPMPresent)' == 'True' "/>
+          Condition=" '$(BuildSdkRpm)' == 'True' and '$(FPMPresent)' == 'True' "/>
 
   <Target Name="GenerateSdkRpm"
           DependsOnTargets="SetupRpmProps">
@@ -317,14 +317,12 @@
       <FPMPresent Condition=" '$(FPMExitCode)' == '0' ">True</FPMPresent>
     </PropertyGroup>
 
-    <!-- Workaround for Jenkins machines that don't have the necessary packages https://github.com/dotnet/core-setup/issues/2260 -->
-    <Message Condition=" '$(FPMPresent)' != 'True' "
-             Text="FPM tool Not found, RPM packages will not be built."
-             Importance="High"/>
+    <Error Condition=" '$(FPMPresent)' != 'True' "
+           Text="FPM tool Not found, RPM packages will not be built." />
   </Target>
 
   <Target Name="TestSdkRpm"
-          Condition="  '$(CLIBUILD_SKIP_TESTS)' != 'true' and '$(IsRPMBasedDistro)' == 'True' and '$(FPMPresent)' == 'True' "
+          Condition="  '$(CLIBUILD_SKIP_TESTS)' != 'true' and '$(BuildSdkRpm)' == 'True' and '$(FPMPresent)' == 'True' "
           Inputs="$(DownloadedNetCoreAppTargetingPackInstallerFile);
                   $(DownloadedNetStandardTargetingPackInstallerFile);
                   $(DownloadedNetCoreAppHostPackInstallerFile);