Skip to content

Make License Pipeline not Source-Build Specific #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Make License Pipeline not Source-Build Specific #19201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c9a38
Install .NET SDK with tools.sh
ellahathaway Mar 26, 2024
196f87d
Rename yml
ellahathaway Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions eng/pipelines/source-build-license-scan.yml → eng/pipelines/vmr-license-scan.yml
View file
Open in desktop
Copy link
Member

@MichaelSimons MichaelSimons Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this better belong in src/SourceBuild/content/eng/pipelines? This feels like the better location given it only runs against the VMR.

Copy link
Member Author

@ellahathaway ellahathaway Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline with @mthalman, and we agreed that the yml is not specific to installer, so it makes sense to move it. However, there are multiple ymls that fit this condition, so I think this is a bigger issue.

I've opened dotnet/source-build#4261 in response.

Copy link
Member

@MichaelSimons MichaelSimons Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I mentioned this one because it was already being renamed/updated.

Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ jobs:
matrix: $[ dependencies.Setup.outputs['GetMatrix.matrix'] ]
steps:

- script: $(Build.SourcesDirectory)/prep-source-build.sh --no-artifacts --no-bootstrap --no-prebuilts --no-binary-removal
displayName: 'Install .NET SDK'
- script: |
source ./eng/common/tools.sh
InitializeDotNetCli true
displayName: Install .NET SDK
workingDirectory: $(Build.SourcesDirectory)

- task: PipAuthenticate@1
displayName: 'Pip Authenticate'
Expand Down