Make License Pipeline not Source-Build Specific #19201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Does this better belong in src/SourceBuild/content/eng/pipelines? This feels like the better location given it only runs against the VMR.
There was a problem hiding this comment.
Discussed offline with @mthalman, and we agreed that the yml is not specific to installer, so it makes sense to move it. However, there are multiple ymls that fit this condition, so I think this is a bigger issue.
I've opened dotnet/source-build#4261 in response.
There was a problem hiding this comment.
That's fair. I mentioned this one because it was already being renamed/updated.
mthalman
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#4091
This PR renames the license scanner yml to
vmr-license-scanand useseng/common/tools.shinstead ofprep-source-build.shto install the .NET SDK.Sample run with yml changes (internal Microsoft link).
As part of this work, the pipeline will need to be manually updated to use the newly named yml.