Further possible fix to reduce memory usage #6390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Apr 8, 2019
TIHan
approved these changes
Apr 8, 2019
Contributor
Author
|
@KevinRansom I prefer this one to #6389 @TIHan What do you think? @davidkean may also want to review |
Contributor
|
Thanks |
brettfo
added a commit
that referenced
this pull request
Apr 9, 2019
Member
|
FYI, I just had to revert this in #6468 due to a build failure in |
KevinRansom
pushed a commit
that referenced
this pull request
Apr 9, 2019
Contributor
|
Pr to fix build issue for #648:
|
Contributor
Author
|
@auduchinok asked about this. The use of two caches is explained by these two comments: |
8 tasks
Contributor
|
I have evaluated this change and with the current internal project that I've been testing, this significantly reduced memory consumption after a find all refs. Before, we would reach 2.6gb in VS process, and now it hits 1.9gb specifically with this change. This is fantastic. I was wondering why 16.1 was not hitting the 2.6gb limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TIHan and others have noticed excessive creation of ILModuleReader. Here's a second possible fix, to be evaluated
The first possible fix is at #6389