Possible fixes to reduce VS memory usage #6389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should also have a tracking issue with concrete data on the number (8000+) of entities based on the dump file we've been working on cc @TIHan |
TIHan
reviewed
Apr 3, 2019
|
|
||
| // All the caches. The sizes are guesstimates for the rough sharing-density of the assembly | ||
| let cacheAssemblyRef = mkCacheInt32 reduceMemoryUsage inbase "ILAssemblyRef" (getNumRows TableNames.AssemblyRef) | ||
| let cacheAssemblyRef = mkCacheInt32 false inbase "ILAssemblyRef" (getNumRows TableNames.AssemblyRef) |
Contributor
There was a problem hiding this comment.
Why not make everything "false" here? I feel like we should be caching everything.
Contributor
Author
There was a problem hiding this comment.
Becasause
- These caches themselves take space
- It's not clear it's worth it - if the items aren't being duplicated in long term storage the cache isn't worth it - so we should work based off evidence that duplication is happening.
TIHan
reviewed
Apr 3, 2019
| let ilModuleReaderCacheLock = Lock() | ||
|
|
||
| // // Cache to extend the lifetime of readers that are eligible for GC | ||
| // let ilModuleReaderCache1 = new ConcurrentDictionary<ILModuleReaderCacheKey, ILModuleReader>(HashIdentity.Structural) |
Contributor
There was a problem hiding this comment.
Is commenting this intentional?
Contributor
Author
There was a problem hiding this comment.
See #6390, which keeps both caches and is more conservative.
KevinRansom
approved these changes
Apr 8, 2019
Contributor
|
@dsyme, how shall we choose between these two approaches? |
Contributor
Author
|
Closing this since I think #6390 is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TIHan and others have noticed excessive creation of ILModuleReader. Here's a possible fix, to be evaluated