Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Feb 7, 2018

This removes the dependency on dotnet that I added when this tool was introduced.

@cartermp
Copy link
Contributor

cartermp commented Feb 7, 2018

Won't we still need the CLI/SDK once #4317 is in though?

@brettfo
Copy link
Member Author

brettfo commented Feb 7, 2018

No, those projects can restore/build with the desktop compiler. In fact, I'm doing it that way on purpose, until all projects are SDK-based, and only then do I plan on making the CLI a build requirement.

@brettfo brettfo changed the title use desktop msbuild for assembly version check use fsi for assembly version check Feb 8, 2018
@brettfo brettfo merged commit a7e06a6 into dotnet:dev15.6 Feb 8, 2018
@brettfo brettfo deleted the version-check branch February 8, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants